diff options
author | Cole Faust <colefaust@google.com> | 2024-01-10 12:30:36 -0800 |
---|---|---|
committer | Felipe Leme <felipeal@google.com> | 2024-05-04 05:20:45 +0000 |
commit | 7639d6fae8052d6328c64ac508b8f6438391e5a7 (patch) | |
tree | c69b18850a6972ab33ef9cb10c579ca0b0828f7e | |
parent | a754dc745cc801ce0d64f0d9149eedca6bf3bdfa (diff) | |
download | modules-utils-7639d6fae8052d6328c64ac508b8f6438391e5a7.tar.gz |
Baseline NewApi issues
NewApi is a lint check that you don't call framework methods that were
introduced in versions later than your min_sdk_version. We want to
make this an error, so we're baselineing all existing issues.
This cl was generated automatically, by taking all the NewApi issues
from the reference baselines, and all the non-NewApi issues from the
existing checked in baselines.
Bug: 268261262
Test: Presubmits
Merged-In: Ie29345aef75b8cb3ed569a82238bdecb4548394d
Change-Id: Ie29345aef75b8cb3ed569a82238bdecb4548394d
(cherry picked from commit 4ce2bb2705c93a0cd5116b2c5b4583ee8f45e4c0)
-rw-r--r-- | java/com/android/modules/utils/Android.bp | 3 | ||||
-rw-r--r-- | java/com/android/modules/utils/lint-baseline.xml | 59 | ||||
-rw-r--r-- | java/com/android/modules/utils/testing/Android.bp | 3 | ||||
-rw-r--r-- | java/com/android/modules/utils/testing/lint-baseline.xml | 37 |
4 files changed, 102 insertions, 0 deletions
diff --git a/java/com/android/modules/utils/Android.bp b/java/com/android/modules/utils/Android.bp index 5c45e3e..14b375f 100644 --- a/java/com/android/modules/utils/Android.bp +++ b/java/com/android/modules/utils/Android.bp @@ -87,6 +87,9 @@ java_library { name: "modules-utils-bytesmatcher", defaults: ["modules-utils-defaults"], srcs: ["BytesMatcher.java"], + lint: { + baseline_filename: "lint-baseline.xml", + }, } java_library { diff --git a/java/com/android/modules/utils/lint-baseline.xml b/java/com/android/modules/utils/lint-baseline.xml new file mode 100644 index 0000000..66b7676 --- /dev/null +++ b/java/com/android/modules/utils/lint-baseline.xml @@ -0,0 +1,59 @@ +<?xml version="1.0" encoding="UTF-8"?> +<issues format="6" by="lint 8.4.0-alpha01" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha01"> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 29): `libcore.util.HexEncoding#encodeToString`" + errorLine1=" builder.append(HexEncoding.encodeToString(this.value));" + errorLine2=" ~~~~~~~~~~~~~~"> + <location + file="frameworks/libs/modules-utils/java/com/android/modules/utils/BytesMatcher.java" + line="76" + column="40"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 29): `libcore.util.HexEncoding#encodeToString`" + errorLine1=" builder.append(HexEncoding.encodeToString(this.mask));" + errorLine2=" ~~~~~~~~~~~~~~"> + <location + file="frameworks/libs/modules-utils/java/com/android/modules/utils/BytesMatcher.java" + line="79" + column="44"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 29): `libcore.util.HexEncoding#decode`" + errorLine1=" ruleValue = HexEncoding.decode(value.substring(i + 1, nextMask));" + errorLine2=" ~~~~~~"> + <location + file="frameworks/libs/modules-utils/java/com/android/modules/utils/BytesMatcher.java" + line="267" + column="41"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 29): `libcore.util.HexEncoding#decode`" + errorLine1=" ruleMask = HexEncoding.decode(value.substring(nextMask + 1, nextRule));" + errorLine2=" ~~~~~~"> + <location + file="frameworks/libs/modules-utils/java/com/android/modules/utils/BytesMatcher.java" + line="268" + column="40"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 29): `libcore.util.HexEncoding#decode`" + errorLine1=" ruleValue = HexEncoding.decode(value.substring(i + 1, nextRule));" + errorLine2=" ~~~~~~"> + <location + file="frameworks/libs/modules-utils/java/com/android/modules/utils/BytesMatcher.java" + line="270" + column="41"/> + </issue> + +</issues>
\ No newline at end of file diff --git a/java/com/android/modules/utils/testing/Android.bp b/java/com/android/modules/utils/testing/Android.bp index a9406d8..4b285f1 100644 --- a/java/com/android/modules/utils/testing/Android.bp +++ b/java/com/android/modules/utils/testing/Android.bp @@ -52,6 +52,9 @@ java_library { sdk_version: "module_current", min_sdk_version: "29", visibility: ["//visibility:public"], + lint: { + baseline_filename: "lint-baseline.xml", + }, } // TODO(b/281577492): split in 2 (one for just ExtendedMockito stuff) diff --git a/java/com/android/modules/utils/testing/lint-baseline.xml b/java/com/android/modules/utils/testing/lint-baseline.xml new file mode 100644 index 0000000..83f171b --- /dev/null +++ b/java/com/android/modules/utils/testing/lint-baseline.xml @@ -0,0 +1,37 @@ +<?xml version="1.0" encoding="UTF-8"?> +<issues format="6" by="lint 8.4.0-alpha01" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha01"> + + <issue + id="NewApi" + message="Call requires API level 30 (current min is 29): `new android.provider.DeviceConfig.Properties.Builder`" + errorLine1=" Properties.Builder builder = new Properties.Builder(namespace);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="frameworks/libs/modules-utils/java/com/android/modules/utils/testing/TestableDeviceConfig.java" + line="193" + column="38"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 30 (current min is 29): `android.provider.DeviceConfig.Properties.Builder#setString`" + errorLine1=" builder.setString(k, v);" + errorLine2=" ~~~~~~~~~"> + <location + file="frameworks/libs/modules-utils/java/com/android/modules/utils/testing/TestableDeviceConfig.java" + line="195" + column="21"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 30 (current min is 29): `android.provider.DeviceConfig.Properties.Builder#build`" + errorLine1=" Properties properties = spy(builder.build());" + errorLine2=" ~~~~~"> + <location + file="frameworks/libs/modules-utils/java/com/android/modules/utils/testing/TestableDeviceConfig.java" + line="197" + column="45"/> + </issue> + +</issues>
\ No newline at end of file |