aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJiyong Park <jiyong@google.com>2024-05-01 16:17:36 +0900
committerJiyong Park <jiyong@google.com>2024-05-01 21:15:33 +0900
commit21a895548df7de83ce1e2e146e1718e5f723af7f (patch)
tree69ebdaf6c73818287fa2be4f8a4e105f3b07c142
parent886fdbbf29390e4a7298da65e46d976a27b4460c (diff)
downloade2fsprogs-21a895548df7de83ce1e2e146e1718e5f723af7f.tar.gz
Use no_full_install: true instead of installable: false
So far, we have used `instalable: false` to avoid collision with the other modules that are installed to the same path. A typical example was <foo> and <foo>.microdroid. The latter is a modified version of the former for the inclusion of the microdroid image. They however both have the same instalation path (ex: system/bin) and stem (ex: foo) so that we can reference them using the same path regardless of whether we are in Android or microdroid. However, the use of `installable: false` for the purpose is actually incorrect, because `installable: false` also means, obviously, "this module shouldn't be installed". The only reason this incorrect way has worked is simply because packaging modules (ex: android_filesystem) didn't respect the property when gathering the modules. As packaging modules are now fixed to respect `installable: false`, we need a correct way of avoiding the collision. `no_full_install: true` is it. If a module has this property set to true, it is never installed to the full instal path like out/target/product/<partition>/... It can be installed only via packaging modules. Bug: 338160898 Test: m Change-Id: Idb173a7e3528c96b23f857bb3bdf5f37e698c445
-rw-r--r--misc/Android.bp2
1 files changed, 1 insertions, 1 deletions
diff --git a/misc/Android.bp b/misc/Android.bp
index 846edf95..4edac23e 100644
--- a/misc/Android.bp
+++ b/misc/Android.bp
@@ -128,7 +128,7 @@ cc_binary {
symlinks: ["mkfs.ext4.microdroid"],
},
},
- installable: false,
+ no_full_install: true,
stem: "mke2fs",
visibility: ["//packages/modules/Virtualization/microdroid"],
}