summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarlos Llamas <cmllamas@google.com>2024-03-30 19:01:14 +0000
committermdb:android-git <superproject-auto-update@invalid>2024-04-18 18:16:00 +0000
commit62dfb1e6405ca7da825750ce72262d5463bc1ffe (patch)
tree002279ca7ca17b72976836e34b9963f049e94fa7
parent5b1304a6d57a23666e57d7b16ca541e3a2388d31 (diff)
downloadsuperproject-common-android12-5.10-2023-04.tar.gz
FROMLIST: binder: check offset alignment in binder_get_object()common-android12-5.10-2023-04
Commit 6d98eb95b450 ("binder: avoid potential data leakage when copying txn") introduced changes to how binder objects are copied. In doing so, it unintentionally removed an offset alignment check done through calls to binder_alloc_copy_from_buffer() -> check_buffer(). These calls were replaced in binder_get_object() with copy_from_user(), so now an explicit offset alignment check is needed here. This avoids later complications when unwinding the objects gets harder. It is worth noting this check existed prior to commit 7a67a39320df ("binder: add function to copy binder object from buffer"), likely removed due to redundancy at the time. Fixes: 6d98eb95b450 ("binder: avoid potential data leakage when copying txn") Cc: <stable@vger.kernel.org> Acked-by: Todd Kjos <tkjos@google.com> Signed-off-by: Carlos Llamas <cmllamas@google.com> Bug: 320661088 Bug: 332642003 Link: https://lore.kernel.org/all/20240330190115.1877819-1-cmllamas@google.com/ Signed-off-by: Carlos Llamas <cmllamas@google.com> Change-Id: Iaddabaa28de7ba7b7d35dbb639d38ca79dbc5077 Bug: 332642003 Signed-off-by: Pindar Yang <pindaryang@google.com> (cherry picked from commit 7859c5c9ebc6b0201ea804078a2329184b58ace5) Signed-off-by: Lee Jones <joneslee@google.com>
m---------common0
1 files changed, 0 insertions, 0 deletions
diff --git a/common b/common
-Subproject 5a3d57a3a6782ea9fe768c0055d107399b2b30d
+Subproject 06b0e491912c3b051d16b2b702659670eb1aa90