diff options
author | Eva Huang <evahuang@google.com> | 2020-03-31 15:38:46 +0800 |
---|---|---|
committer | Eva Huang <evahuang@google.com> | 2020-03-31 15:39:04 +0800 |
commit | df3ca60d978c57aca37b27b059622557837d05a1 (patch) | |
tree | eeee6773e9d26ae2a40c3d7f4d35a0772cd080e4 | |
parent | ed115990f9ad5c705c8d0368aee026bbfaab7468 (diff) | |
download | msm-android-msm-crosshatch-4.9-android10-qpr2.tar.gz |
Revert "do_last(): fetch directory ->i_mode and ->i_uid before it's too late"android-10.0.0_r0.62android-10.0.0_r0.61android-msm-crosshatch-4.9-android10-qpr2android-msm-bonito-4.9-android10-qpr2
This reverts commit ba4aa0a6a521f905ff73d99d519911955c0f6df0.
Bug: 151975972
Change-Id: I4b1057b2f1dbebdcdf7fbb4c0de4c4a7a11be300
-rw-r--r-- | fs/namei.c | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/fs/namei.c b/fs/namei.c index 0531e967d8bc..d8f858484538 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1026,8 +1026,7 @@ static int may_linkat(struct path *link) * may_create_in_sticky - Check whether an O_CREAT open in a sticky directory * should be allowed, or not, on files that already * exist. - * @dir_mode: mode bits of directory - * @dir_uid: owner of directory + * @dir: the sticky parent directory * @inode: the inode of the file to open * * Block an O_CREAT open of a FIFO (or a regular file) when: @@ -1043,18 +1042,18 @@ static int may_linkat(struct path *link) * * Returns 0 if the open is allowed, -ve on error. */ -static int may_create_in_sticky(umode_t dir_mode, kuid_t dir_uid, +static int may_create_in_sticky(struct dentry * const dir, struct inode * const inode) { if ((!sysctl_protected_fifos && S_ISFIFO(inode->i_mode)) || (!sysctl_protected_regular && S_ISREG(inode->i_mode)) || - likely(!(dir_mode & S_ISVTX)) || - uid_eq(inode->i_uid, dir_uid) || + likely(!(dir->d_inode->i_mode & S_ISVTX)) || + uid_eq(inode->i_uid, dir->d_inode->i_uid) || uid_eq(current_fsuid(), inode->i_uid)) return 0; - if (likely(dir_mode & 0002) || - (dir_mode & 0020 && + if (likely(dir->d_inode->i_mode & 0002) || + (dir->d_inode->i_mode & 0020 && ((sysctl_protected_fifos >= 2 && S_ISFIFO(inode->i_mode)) || (sysctl_protected_regular >= 2 && S_ISREG(inode->i_mode))))) { return -EACCES; @@ -3296,8 +3295,6 @@ static int do_last(struct nameidata *nd, int *opened) { struct dentry *dir = nd->path.dentry; - kuid_t dir_uid = dir->d_inode->i_uid; - umode_t dir_mode = dir->d_inode->i_mode; int open_flag = op->open_flag; bool will_truncate = (open_flag & O_TRUNC) != 0; bool got_write = false; @@ -3440,7 +3437,7 @@ finish_open: error = -EISDIR; if (d_is_dir(nd->path.dentry)) goto out; - error = may_create_in_sticky(dir_mode, dir_uid, + error = may_create_in_sticky(dir, d_backing_inode(nd->path.dentry)); if (unlikely(error)) goto out; |