diff options
| author | Tor Norbye <tnorbye@google.com> | 2020-06-03 19:06:32 -0700 |
|---|---|---|
| committer | Tor Norbye <tnorbye@google.com> | 2020-06-03 19:06:32 -0700 |
| commit | 581900c095d4795351b4ff3978ed821c8a4e9e57 (patch) | |
| tree | cadd4cb6327b0eba6e3d74aea4ab348d79777481 | |
| parent | 83d5a93853c839c5d2da3caf64879f6e94e4dd85 (diff) | |
| download | samples-581900c095d4795351b4ff3978ed821c8a4e9e57.tar.gz | |
Add lint checks to the google/samples project
A lot of the Bazel configurations for various projects
were not applying the Studio-local lint checks which
enforce various recommendations and practices for
our codebase.
Test: This is it, run at build time
Bug: None
Change-Id: Iebae62020015463706ae9f9ea2403481af4b83ab
| -rw-r--r-- | BUILD | 1 | ||||
| -rw-r--r-- | lint_baseline.xml | 28 |
2 files changed, 29 insertions, 0 deletions
@@ -5,6 +5,7 @@ iml_module( name = "google-samples", srcs = ["src"], iml_files = ["google-samples.iml"], + lint_baseline = "lint_baseline.xml", # do not sort: must match IML order test_runtime_deps = [ "//tools/idea/plugins/java-decompiler/plugin:intellij.java.decompiler", diff --git a/lint_baseline.xml b/lint_baseline.xml new file mode 100644 index 0000000..33867b7 --- /dev/null +++ b/lint_baseline.xml @@ -0,0 +1,28 @@ +<?xml version="1.0" encoding="UTF-8"?> +<issues format="5" by="lint 4.2.0-dev"> + + <issue + id="DefaultLocale" + message="Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead"> + <location + file="src/com/google/devrel/cluestick/studioclient/CodeBrowser.java" + line="182"/> + </issue> + + <issue + id="UseValueOf" + message="Use `Integer.valueOf(signal)` instead"> + <location + file="src/com/google/devrel/cluestick/searchservice/EventLog.java" + line="65"/> + </issue> + + <issue + id="UseValueOf" + message="Use `Integer.valueOf(signalObject.intValue() + signal)` instead"> + <location + file="src/com/google/devrel/cluestick/searchservice/EventLog.java" + line="67"/> + </issue> + +</issues> |