aboutsummaryrefslogtreecommitdiff
path: root/tvloader/parser2v2
diff options
context:
space:
mode:
authorspecter25 <ujjwalcoding012@gmail.com>2021-05-12 22:11:11 +0530
committerspecter25 <ujjwalcoding012@gmail.com>2021-05-12 22:11:11 +0530
commitb5d120102fa763bbe482a85a00d9a4d4b4e34657 (patch)
treec0f974e6b6f2d3c5724069023b976ed279e9eb1e /tvloader/parser2v2
parent4efac7b1447c34fd10fa3b5a8cdb1e690d2b6be6 (diff)
downloadspdx-tools-b5d120102fa763bbe482a85a00d9a4d4b4e34657.tar.gz
Units Tests in tvloader structured and a few tests added
Signed-off-by: specter25 <ujjwalcoding012@gmail.com>
Diffstat (limited to 'tvloader/parser2v2')
-rw-r--r--tvloader/parser2v2/parse_file_test.go8
-rw-r--r--tvloader/parser2v2/parse_snippet_test.go18
2 files changed, 22 insertions, 4 deletions
diff --git a/tvloader/parser2v2/parse_file_test.go b/tvloader/parser2v2/parse_file_test.go
index 6b8f878..c0cbe92 100644
--- a/tvloader/parser2v2/parse_file_test.go
+++ b/tvloader/parser2v2/parse_file_test.go
@@ -934,13 +934,13 @@ func TestParser2_2FilesWithoutSpdxIdThrowError(t *testing.T) {
// case 2 : Invalid file with snippet
// Last unpackaged file before the snippet start
// Last file of a package and New package starts
+ fileName := "f2.txt"
sid1 := spdx.ElementID("s1")
parser2 := tvParser2_2{
- doc: &spdx.Document2_2{},
- st: psCreationInfo2_2,
+ doc: &spdx.Document2_2{},
+ st: psCreationInfo2_2,
+ file: &spdx.File2_2{FileName: fileName},
}
- fileName := "f2.txt"
- _ = parser2.parsePair2_2("FileName", fileName)
err = parser2.parsePair2_2("SnippetSPDXID", string(sid1))
if err == nil {
t.Errorf("files withoutSpdx Identifiers getting accepted")
diff --git a/tvloader/parser2v2/parse_snippet_test.go b/tvloader/parser2v2/parse_snippet_test.go
index 987fe2a..1cabe3c 100644
--- a/tvloader/parser2v2/parse_snippet_test.go
+++ b/tvloader/parser2v2/parse_snippet_test.go
@@ -614,3 +614,21 @@ func TestParser2_2FailsForInvalidSnippetLineValues(t *testing.T) {
t.Errorf("expected non-nil error, got nil")
}
}
+
+func TestParser2_2FilesWithoutSpdxIdThrowErrorWithSniipets(t *testing.T) {
+ // Invalid file with snippet
+ // Last unpackaged file before the snippet start
+ // Last file of a package and New package starts
+ fileName := "f2.txt"
+ sid1 := spdx.ElementID("s1")
+ parser2 := tvParser2_2{
+ doc: &spdx.Document2_2{},
+ st: psCreationInfo2_2,
+ file: &spdx.File2_2{FileName: fileName},
+ }
+ err := parser2.parsePair2_2("SnippetSPDXID", string(sid1))
+ if err == nil {
+ t.Errorf("files withoutSpdx Identifiers getting accepted")
+ }
+
+}