aboutsummaryrefslogtreecommitdiff
path: root/tvloader/parser2v1/parse_creation_info.go
diff options
context:
space:
mode:
authorSteve Winslow <steve@swinslow.net>2021-07-04 10:54:31 -0400
committerSteve Winslow <steve@swinslow.net>2021-07-04 10:54:31 -0400
commitb238c888559fcfaba7abc4d73741b633746c10d2 (patch)
tree9533e565af699fe44069e9ee3b1e3f02061191f3 /tvloader/parser2v1/parse_creation_info.go
parentb5d120102fa763bbe482a85a00d9a4d4b4e34657 (diff)
downloadspdx-tools-b238c888559fcfaba7abc4d73741b633746c10d2.tar.gz
Minor cleanup edits to text and comments
Signed-off-by: Steve Winslow <steve@swinslow.net>
Diffstat (limited to 'tvloader/parser2v1/parse_creation_info.go')
-rw-r--r--tvloader/parser2v1/parse_creation_info.go7
1 files changed, 5 insertions, 2 deletions
diff --git a/tvloader/parser2v1/parse_creation_info.go b/tvloader/parser2v1/parse_creation_info.go
index dd9a004..8742bf2 100644
--- a/tvloader/parser2v1/parse_creation_info.go
+++ b/tvloader/parser2v1/parse_creation_info.go
@@ -76,8 +76,11 @@ func (parser *tvParser2_1) parsePairFromCreationInfo2_1(tag string, value string
// tag for going on to package section
case "PackageName":
- // Error if last file does not has FileSPDXId
- if parser.file != nil && parser.file.FileSPDXIdentifier == spdx.ElementID("") {
+ // error if last file does not have an identifier
+ // this may be a null case: can we ever have a "last file" in
+ // the "creation info" state? should go on to "file" state
+ // even when parsing unpackaged files.
+ if parser.file != nil && parser.file.FileSPDXIdentifier == nullSpdxElementId2_1 {
return fmt.Errorf("file with FileName %s does not have SPDX identifier", parser.file.FileName)
}
parser.st = psPackage2_1