diff options
| -rw-r--r-- | ChangeLog | 2 | ||||
| -rw-r--r-- | debian/changelog | 2 | ||||
| -rw-r--r-- | doc/sg_ident.8 | 8 | ||||
| -rw-r--r-- | doc/sg_inq.8 | 68 | ||||
| -rw-r--r-- | doc/sg_logs.8 | 66 | ||||
| -rw-r--r-- | include/sg_pr2serr.h | 13 | ||||
| -rw-r--r-- | lib/sg_cmds_extra.c | 1 | ||||
| -rw-r--r-- | lib/sg_lib.c | 9 | ||||
| -rw-r--r-- | lib/sg_lib_data.c | 2 | ||||
| -rw-r--r-- | sg3_utils.spec | 2 | ||||
| -rw-r--r-- | src/sg_ident.c | 6 |
11 files changed, 101 insertions, 78 deletions
@@ -2,7 +2,7 @@ Each utility has its own version number, date of last change and some description at the top of its ".c" file. All utilities in the main directory have their own "man" pages. There is also a sg3_utils man page. -Changelog for sg3_utils-1.43 [20180812] [svn: r786] +Changelog for sg3_utils-1.43 [20180815] [svn: r787] - sg_write_x: where x can be normal, atomic, or(write), same, scattered, or stream writes with 16 or 32 byte cdbs (sbc4r04 for atomic, sbc4r11 for scattered) diff --git a/debian/changelog b/debian/changelog index 9e2d6063..f9052c81 100644 --- a/debian/changelog +++ b/debian/changelog @@ -2,7 +2,7 @@ sg3-utils (1.43-0.1) unstable; urgency=low * New upstream version - -- Douglas Gilbert <dgilbert@interlog.com> Wed, 08 Aug 2018 17:00:00 -0400 + -- Douglas Gilbert <dgilbert@interlog.com> Wed, 15 Aug 2018 10:00:00 -0400 sg3-utils (1.42-0.1) unstable; urgency=low diff --git a/doc/sg_ident.8 b/doc/sg_ident.8 index e223bea9..76e0b31e 100644 --- a/doc/sg_ident.8 +++ b/doc/sg_ident.8 @@ -1,4 +1,4 @@ -.TH SG_IDENT "8" "November 2012" "sg3_utils\-1.35" SG3_UTILS +.TH SG_IDENT "8" "August 2018" "sg3_utils\-1.43" SG3_UTILS .SH NAME sg_ident \- send SCSI REPORT/SET IDENTIFYING INFORMATION command .SH SYNOPSIS @@ -36,8 +36,8 @@ Arguments to long options are mandatory for short options as well. .TP \fB\-A\fR, \fB\-\-ascii\fR invokes the Report Identifying Information command and if anything is -found interprets it as ASCII (or UTF\-8 depending on the locale) -and prints the information to stdout. +found interprets it as ASCII (or UTF\-8 which is locale dependent) and +prints the information to stdout. .TP \fB\-C\fR, \fB\-\-clear\fR invokes the Set Identifying Information command with an information length @@ -111,7 +111,7 @@ Written by Douglas Gilbert. .SH "REPORTING BUGS" Report bugs to <dgilbert at interlog dot com>. .SH COPYRIGHT -Copyright \(co 2005\-2012 Douglas Gilbert +Copyright \(co 2005\-2018 Douglas Gilbert .br This software is distributed under a FreeBSD license. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. diff --git a/doc/sg_inq.8 b/doc/sg_inq.8 index f94a8916..13c41911 100644 --- a/doc/sg_inq.8 +++ b/doc/sg_inq.8 @@ -1,4 +1,4 @@ -.TH SG_INQ "8" "March 2018" "sg3_utils\-1.43" SG3_UTILS +.TH SG_INQ "8" "August 2018" "sg3_utils\-1.43" SG3_UTILS .SH NAME sg_inq \- issue SCSI INQUIRY command and/or decode its response .SH SYNOPSIS @@ -56,7 +56,7 @@ In some operating systems a NVMe device (e.g. SSD) may be given as the The reference document used for interpreting an INQUIRY is T10/BSR INCITS 502 Revision 19 which is draft SPC\-5 revision 19, 14 February 2018). It can be found at http://www.t10.org . Obsolete and reserved items in the standard -INQUIRY response output are displayed in brackets. +INQUIRY response output are displayed in square brackets. .SH OPTIONS Arguments to long options are mandatory for short options as well. The options are arranged in alphabetical order based on the long @@ -83,9 +83,9 @@ set the Command Support Data (CmdDt) bit (defaults to clear(0)). Used in conjunction with the \fI\-\-page=PG\fR option where \fIPG\fR specifies the SCSI command opcode to query. When used twice (e.g. '\-cc') this utility forms a list by looping over all 256 opcodes (0 to 255 inclusive) only -outputting a line for found commands. The CmdDt bit is now obsolete. -It has been replaced by the REPORT SUPPORTED OPERATION CODES command, -see the sg_opcodes(8) utility. +outputting a line for commands that are found. The CmdDt bit is now +obsolete; it has been replaced by the REPORT SUPPORTED OPERATION CODES +command, see the sg_opcodes(8) utility. .TP \fB\-d\fR, \fB\-\-descriptors\fR decodes and prints the version descriptors found in a standard INQUIRY @@ -131,18 +131,18 @@ given to the \fI\-\-page=PG\fR option. .TP \fB\-H\fR, \fB\-\-hex\fR rather than decode a standard INQUIRY response, a VPD page or command -support data; print out the response in hex to stdout. Error messages and -warnings are typically output to stderr. When used twice with the ATA -Information VPD page [0x89] decodes the start of the response then outputs -the ATA IDENTIFY (PACKET) DEVICE response in hexadecimal bytes (not 16 bit -words). When used three times with the ATA Information VPD page [0x89] or -the \fI\-\-ata\fR option, this utility outputs the ATA IDENTIFY (PACKET) -DEVICE response in hexadecimal words suitable for input +support data; print out the response in hex and send the output to stdout. +Error messages and warnings are typically output to stderr. When used twice +with the ATA Information VPD page [0x89] decodes the start of the response +then outputs the ATA IDENTIFY (PACKET) DEVICE response in hexadecimal +bytes (not 16 bit words). When used three times with the ATA Information VPD +page [0x89] or the \fI\-\-ata\fR option, this utility outputs the ATA +IDENTIFY (PACKET) DEVICE response in hexadecimal words suitable for input to 'hdparm \-\-Istdin'. See note below. .br To generate output suitable for placing in a file that can be used by a later invocation with the \fI\-\-inhex=FN\fR option, use the '\-HHHH' -option (e.g. 'sg_inq \-p di -HHHH /dev/sg3 > dev_id.hex'). +option (e.g. 'sg_inq \-p di \-HHHH /dev/sg3 > dev_id.hex'). .TP \fB\-i\fR, \fB\-\-id\fR prints the device identification VPD page [0x83]. @@ -152,17 +152,17 @@ prints the device identification VPD page [0x83]. ASCII hexadecimal or binary representing an INQUIRY (including VPD page) response. This utility will then decode that response. It is preferable to also supply the \fI\-\-page=PG\fR option, if not this utility will attempt -to guess which VPD page (or standard INQUIRY) the response is associated +to guess which VPD page (or standard INQUIRY) that the response is associated with. The hexadecimal should be arranged as 1 or 2 digits representing a byte each of which is whitespace or comma separated. Anything from and -including a hash mark to the end of line is ignored. If the \fI\-\-raw\fR +including a hash mark to the end of a line is ignored. If the \fI\-\-raw\fR option is also given then \fIFN\fR is treated as binary. .TP \fB\-l\fR, \fB\-\-len\fR=\fILEN\fR the number \fILEN\fR is the "allocation length" field in the INQUIRY cdb. -This is the (maximum) length of the response to be sent by the device. -The default value of \fILEN\fR is 0 which is interpreted as: first request -is for 36 bytes and if necessary execute another INQUIRY if the "additional +This is the (maximum) length of the response returned by the device. The +default value of \fILEN\fR is 0 which is interpreted as: first request is +for 36 bytes and if necessary execute another INQUIRY if the "additional length" field in the response indicates that more than 36 bytes is available. .br If \fILEN\fR is greater than 0 then only one INQUIRY command is performed. @@ -179,7 +179,7 @@ this option has the same action as the \fI\-\-len=LEN\fR option above. It has been added for compatibility with the sg_vpd, sg_modes and sg_logs utilities. .TP \fB\-O\fR, \fB\-\-old\fR -Switch to older style options. Please use as first option. +Switch to older style options. Please use as first option on the command line. .TP \fB\-o\fR, \fB\-\-only\fR Do not attempt to additionally retrieve the serial number VPD page (0x80) to @@ -212,15 +212,15 @@ If \fIPG\fR is not found in the 'Supported VPD pages' VPD page (0x0) then EDOM is returned. To bypass this check use the \fI\-\-force\fR option. .TP \fB\-r\fR, \fB\-\-raw\fR -in the absence of \fI\-\-inhex=FN\fR then output response in binary. +in the absence of \fI\-\-inhex=FN\fR then the output response is in binary. The output should be piped to a file or another utility when this option is used. The binary is sent to stdout, and errors are sent to stderr. .br -if used with \fI\-\-inhex=FN\fR then the contents of \fIFN\fR is treated as +If used with \fI\-\-inhex=FN\fR then the contents of \fIFN\fR is treated as binary. .TP \fB\-s\fR, \fB\-\-vendor\fR -output a standard INQUIRY response's vendor specific field from offset 36 +output a standard INQUIRY response's vendor specific fields from offset 36 to 55 in ASCII. When used twice (i.e. '\-ss') also output the vendor specific field from offset 96 in ASCII. This is only done if the data passes some simple sanity checks. @@ -239,15 +239,16 @@ defaults to zero which is the "Supported VPD pages" VPD page. A more up to date decoding of VPD pages can be found in the sg_vpd(8) utility. .SH NOTES Some devices with weak SCSI command set implementations lock up when they -receive commands they don't understand (or even response lengths that they -don't expect). Such devices need to be treated carefully, use the '\-\-len=36' -option. Without this option this utility will issue an initial standard -INQUIRY requesting 36 bytes of response data. If the device indicates it -could have supplied more data then a second INQUIRY is issued to fetch the -longer response. That second command may lock up faulty devices. +receive commands they don't understand (and some lock up if they receive +response lengths that they don't expect). Such devices need to be treated +carefully, use the '\-\-len=36' option. Without this option this utility will +issue an initial standard INQUIRY requesting 36 bytes of response data. If +the device indicates it could have supplied more data then a second INQUIRY +is issued to fetch the longer response. That second command may lock up +faulty devices. .PP ATA or ATAPI devices that use a SCSI to ATA Translation layer (see -SAT at www.t10.org) may support the ATA Information VPD page. This +SAT at www.t10.org) may support the SCSI ATA INFORMATION VPD page. This returns the IDENTIFY (PACKET) DEVICE response amongst other things. The ATA Information VPD page can be fetched with '\-\-page=ai'. .PP @@ -262,8 +263,8 @@ being used for access and the SCSI ports VPD page (0x88) to show all available ports on the device. .PP In the 2.4 series of Linux kernels the \fIDEVICE\fR must be -a SCSI generic (sg) device. In the 2.6 series block devices (e.g. disks -and ATAPI DVDs) can also be specified. For example "sg_inq /dev/sda" +a SCSI generic (sg) device. In the 2.6 series and later block devices (e.g. +disks and ATAPI DVDs) can also be specified. For example "sg_inq /dev/sda" will work in the 2.6 series kernels. From lk 2.6.6 other SCSI "char" device names may be used as well (e.g. "/dev/st0m"). .PP @@ -358,14 +359,15 @@ Equivalent to \fI\-\-ata\fR in the OPTIONS section. .TP \fB\-b\fR decodes the Block Limits VPD page [0xb0]. Equivalent to '\-\-page=bl' in -the OPTIONS section. This page is defined in SBC\-2 (see www.t10.org). +the OPTIONS section. This page is defined in SBC\-2 (see www.t10.org) and +later. .TP \fB\-B\fR=\fI0|1\fR equivalent to \fI\-\-block=0|1\fR in OPTIONS section. .TP \fB\-c\fR set the Command Support Data (CmdDt) bit (defaults to clear(0)). Used in - conjunction with the \fI\-p=VPD_PG\fR option to specify the SCSI command +conjunction with the \fI\-p=VPD_PG\fR option to specify the SCSI command opcode to query. Equivalent to \fI\-\-cmddt\fR in the OPTIONS section. .TP \fB\-cl\fR diff --git a/doc/sg_logs.8 b/doc/sg_logs.8 index f5d2e774..af07a2a4 100644 --- a/doc/sg_logs.8 +++ b/doc/sg_logs.8 @@ -1,4 +1,4 @@ -.TH SG_LOGS "8" "May 2018" "sg3_utils\-1.43" SG3_UTILS +.TH SG_LOGS "8" "August 2018" "sg3_utils\-1.43" SG3_UTILS .SH NAME sg_logs \- access log pages with SCSI LOG SENSE command .SH SYNOPSIS @@ -34,9 +34,12 @@ sg_logs \- access log pages with SCSI LOG SENSE command .\" Add any additional description here .PP This utility sends a SCSI LOG SENSE command to the \fIDEVICE\fR and then -outputs the response. The LOG SENSE command is used to fetch log pages. Known -log pages can be decoded. Alternatively when the \fI\-\-reset\fR and/or -\fI\-\-select\fR option is given then a SCSI LOG SELECT command is issued. +outputs the response. The LOG SENSE command is used to fetch log pages which, +if known, are decoded by default. When the \fI\-\-reset\fR and/or +\fI\-\-select\fR option is given then a SCSI LOG SELECT command is issued +to the \fIDEVICE\fR. Alternatively one or more log page responses can be in +a file read using the \fI\-\-in=FN\fR option; in this case those responses +are decoded and the \fIDEVICE\fR argument, if given, is ignored. .PP In SPC\-4 revision 5 a subpage code was introduced to both the LOG SENSE and LOG SELECT command. At the same time a page code field was introduced to the @@ -59,15 +62,16 @@ option name. \fB\-A\fR, \fB\-\-All\fR fetch and decode all the log pages and subpages supported by the \fIDEVICE\fR. This requires a two stage process: first the "supported log pages and -subpages" log page is fetched, then for each entry in the response, the +subpages" log page is fetched, then for each entry in its response, the corresponding log page (or subpage) is fetched and displayed. Note that there are many SCSI devices that do not support LOG SENSE subpages and respond -to this option with an illegal request sense key. +to this option with an illegal request sense key (or ignored the subpage +field). .TP \fB\-a\fR, \fB\-\-all\fR outputs all the log pages supported by the \fIDEVICE\fR. This requires a two stage process: first the "supported log pages" log page is fetched, then for -each entry in the response, the corresponding log page is fetched and +each entry in its response, the corresponding log page is fetched and displayed. When used twice (e.g. '\-aa') all log pages and subpages are fetched. .TP @@ -91,14 +95,14 @@ The default value is 1 (i.e. current cumulative values). .TP \fB\-e\fR, \fB\-\-enumerate\fR this option is used to output information held in internal tables about -known log pages including their names and acronyms. If given \fIDEVICE\fR -is ignored. When given once (e.g. '\-e') all known pages are listed, sorted -in ascending acronym order. When given twice, vendor pages are excluded. -When given three times, all known pages are listed, sorted in ascending -numeric order listed; when given four times, vendor pages are excluded from -the numeric order. +known log pages including their name, acronym and fields. If given, the +\fIDEVICE\fR argument is ignored. When given once (e.g. '\-e') all known +pages are listed, sorted in ascending acronym order (alphabetic). When +given twice, vendor pages are excluded. When given three times, all known +pages are listed, sorted in ascending numeric order listed; when given four +times, vendor pages are excluded from the numeric order. .br -The \fI\-\-filter=FL\fR and \fI\-\-verbose\fR options modify the output +The \fI\-\-filter=FL\fR and \fI\-\-verbose\fR options reduce the output of the enumeration. .TP \fB\-f\fR, \fB\-\-filter\fR=\fIFL\fR @@ -110,9 +114,9 @@ and only the parameter section matching that code is output. If the \fB\-\-hex\fR option is given the log parameter is output in hexadecimal rather than decoding it. If the \fB\-\-hex\fR option is used twice then the leading address on each line of hex is removed. If the \fB\-\-raw\fR option -is given then the log parameter is output in binary. -Most log pages contain one or more log parameters. Examples of those that -don't are those pages that list supported log pages. +is given then the log parameter is output in binary. Most log pages contain +one or more log parameters. Examples of those that don't follow that +convention are those pages that list supported log pages (and subpages). .br In the \fI\-\-enumerate\fR case, when \fIFL\fR >= zero it is taken as a pdt value and only log pages associated with that pdt plus generic pages @@ -127,7 +131,7 @@ are enumerated. print out the usage message then exit. .TP \fB\-H\fR, \fB\-\-hex\fR -The default action is to decode known mode page numbers (and subpage numbers) +The default action is to decode known log page numbers (and subpage numbers) into text. When this option is used once, the response is output in hexadecimal. When used twice, each line of hex has the ASCII equivalent shown to the right. When used three times, the hex has no leading address nor @@ -240,15 +244,16 @@ open on \fIDEVICE\fR and if it fails, this utility will exit. Note that options like \fI\-\-select\fR most likely need a read\-write open. .TP \fB\-R\fR, \fB\-\-reset\fR -use SCSI LOG SELECT command (PCR bit set) to reset the all log pages (or -the given page). Exactly what is reset depends on the accompanying SP -bit (i.e. \fI\-\-sp\fR option which defaults to 0) and the +use SCSI LOG SELECT command (with the PCR bit set) to reset the all log +pages (or the given page). Exactly what is reset depends on the accompanying +SP bit (i.e. \fI\-\-sp\fR option which defaults to 0) and the \fIPC\fR ("page control") value (which defaults to 1). Supplying this option implies the \fI\-\-select\fR option as well. This option seems to clear error counter log pages but leaves pages like self\-test results, start\-stop cycle counter and temperature log pages unaffected. This option may be required to clear log pages if a counter reaches its maximum value since the log page in -which the counter is found will remain "stuck" until something is done. +which the counter is found will remain "stuck" at its maximum value until +some user interaction (e.g. calling sg_logs with this option). .TP \fB\-S\fR, \fB\-\-select\fR use a LOG SELECT command. The default action (i.e. when neither this option @@ -296,17 +301,18 @@ are followed by "[hex only]". \fB\-V\fR, \fB\-\-version\fR print out version string then exit. .SH LOG SELECT -The LOG SELECT command can be used to reset certain parameters to vendor +The SCSI LOG SELECT command can be used to reset certain parameters to vendor specific defaults, save them to non\-volatile storage (i.e. the media), or supply new page contents. This command has changed between SPC\-3 and SPC\-4 with the addition of the Page and Subpage Code fields which can only be non zero when the Parameter list length is zero. .PP -The \fI\-\-select\fR option is required to issue a LOG SELECT command. If -the \fI\-\-in=FN\fR option is not given (or \fIFN\fR is effectively empty) -then the Parameter list length field is set to zero. If the \fI\-\-in=FN\fR -option is is given then its decoded data is placed in the data\-out buffer -and its length in bytes is placed in the Parameter list length field. +The \fI\-\-select\fR (or \fI\-\-reset\fR) option is required to issue a LOG +SELECT command. If the \fI\-\-in=FN\fR option is not given (or \fIFN\fR is +effectively empty) then the Parameter list length field is set to zero. If +the \fI\-\-in=FN\fR option is is given then its decoded data is placed in +the data\-out buffer and its length in bytes is placed in the Parameter list +length field. .PP Other options that are active with the LOG SELECT command are \fI\-\-control=PC\fR, \fI\-\-reset\fR (which sets the PCR bit) and @@ -335,8 +341,8 @@ work in the standards. However some older devices don't comply. For those devices using the \fI\-\-maxlen=LEN\fR option will do a single fetch. A value of 252 should be a safe starting point. .PP -Various log pages hold information error rates, device temperature, -start stop cycles since device produced and the results of the last +Various log pages hold information error rates, device temperature, start +stop cycles since the device was produced and the results of the last 20 self tests. Self tests can be initiated by the sg_senddiag(8) utility. The smartmontools package provides much of the information found with sg_logs in a form suitable for monitoring the health of SCSI disks and diff --git a/include/sg_pr2serr.h b/include/sg_pr2serr.h index 840cec26..c317f5bb 100644 --- a/include/sg_pr2serr.h +++ b/include/sg_pr2serr.h @@ -32,6 +32,16 @@ extern "C" { #if defined(__GNUC__) || defined(__clang__) +#ifdef SG_LIB_MINGW +/* MinGW uses Microsoft's printf */ +int pr2serr(const char * fmt, ...); + +int pr2ws(const char * fmt, ...); + +int sg_scnpr(char * cp, int cp_max_len, const char * fmt, ...); + +#else /* GNU/clang other than MinGW */ + int pr2serr(const char * fmt, ...) __attribute__ ((format (printf, 1, 2))); @@ -40,8 +50,9 @@ int pr2ws(const char * fmt, ...) int sg_scnpr(char * cp, int cp_max_len, const char * fmt, ...) __attribute__ ((format (printf, 3, 4))); +#endif -#else +#else /* not GNU (and not clang) */ int pr2serr(const char * fmt, ...); diff --git a/lib/sg_cmds_extra.c b/lib/sg_cmds_extra.c index 90168969..97f80fef 100644 --- a/lib/sg_cmds_extra.c +++ b/lib/sg_cmds_extra.c @@ -8,6 +8,7 @@ #include <stdio.h> #include <stdlib.h> #include <stdarg.h> +#include <stdint.h> #include <string.h> #include <errno.h> #include <unistd.h> diff --git a/lib/sg_lib.c b/lib/sg_lib.c index e23dfc6d..092de1a1 100644 --- a/lib/sg_lib.c +++ b/lib/sg_lib.c @@ -28,13 +28,14 @@ */ #define _POSIX_C_SOURCE 200809L /* for posix_memalign() */ -#define __STDC_FORMAT_MACROS 1 #include <stdio.h> #include <stdlib.h> #include <stdarg.h> #include <stdbool.h> +#include <stdint.h> #include <string.h> #include <ctype.h> +#define __STDC_FORMAT_MACROS 1 #include <inttypes.h> #include <errno.h> #include <unistd.h> @@ -3351,9 +3352,6 @@ pr2serr(const char * fmt, ...) #include <sys/param.h> #elif defined(SG_LIB_WIN32) #include <windows.h> - -static bool got_page_size = false; -static uint32_t win_page_size; #endif uint32_t @@ -3362,6 +3360,9 @@ sg_get_page_size(void) #if defined(HAVE_SYSCONF) && defined(_SC_PAGESIZE) return sysconf(_SC_PAGESIZE); /* POSIX.1 (was getpagesize()) */ #elif defined(SG_LIB_WIN32) + static bool got_page_size = false; + static uint32_t win_page_size; + if (! got_page_size) { SYSTEM_INFO si; diff --git a/lib/sg_lib_data.c b/lib/sg_lib_data.c index 3f5f21d9..efc81b47 100644 --- a/lib/sg_lib_data.c +++ b/lib/sg_lib_data.c @@ -17,7 +17,7 @@ #include "sg_lib_data.h" -const char * sg_lib_version_str = "2.54 20180808";/* spc5r19, sbc4r15 */ +const char * sg_lib_version_str = "2.55 20180814";/* spc5r19, sbc4r15 */ /* indexed by pdt; those that map to own index do not decay */ diff --git a/sg3_utils.spec b/sg3_utils.spec index 22167bf1..9afa438b 100644 --- a/sg3_utils.spec +++ b/sg3_utils.spec @@ -84,7 +84,7 @@ fi %{_libdir}/*.la %changelog -* Wed Aug 08 2018 - dgilbert at interlog dot com +* Wed Aug 15 2018 - dgilbert at interlog dot com - track t10 changes * sg3_utils-1.43 diff --git a/src/sg_ident.c b/src/sg_ident.c index e5629bea..f75fb110 100644 --- a/src/sg_ident.c +++ b/src/sg_ident.c @@ -31,7 +31,7 @@ * DEVICE IDENTIFIER and SET DEVICE IDENTIFIER prior to spc4r07. */ -static const char * version_str = "1.22 20180626"; +static const char * version_str = "1.23 20180814"; #define ME "sg_ident: " @@ -109,7 +109,9 @@ usage(void) " --verbose|-v increase verbosity of output\n" " --version|-V print version string and exit\n\n" "Performs a SCSI REPORT (or SET) IDENTIFYING INFORMATION " - "command\n"); + "command. When no\noptions are given then REPORT IDENTIFYING " + "INFORMATION is sent and the\nresponse is output in " + "hexadecimal with ASCII to the right.\n"); } int |