From f6646105b9b8d9b5912f606da818d614b3171f78 Mon Sep 17 00:00:00 2001 From: Neelkamal Semwal Date: Thu, 8 Jul 2021 09:15:53 +0530 Subject: libOpus: fix integer overflow in silk_resampler_down2_hp Bug: 190882774 Test: poc in bug description Change-Id: Ib780a7d3e114ed29047c50459c01462c6b244f31 --- src/analysis.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/analysis.c b/src/analysis.c index 058328f0..8b4f22d0 100644 --- a/src/analysis.c +++ b/src/analysis.c @@ -149,7 +149,10 @@ static opus_val32 silk_resampler_down2_hp( out32_hp = ADD32( out32_hp, X ); S[ 2 ] = ADD32( -in32, X ); - hp_ener += out32_hp*(opus_val64)out32_hp; + if(__builtin_add_overflow(hp_ener, out32_hp*(opus_val64)out32_hp, &hp_ener)) + { + hp_ener = UINT64_MAX; + } /* Add, convert back to int16 and store to output */ out[ k ] = HALF32(out32); } -- cgit v1.2.3