Age | Commit message (Collapse) | Author |
|
Few SIMD functions read 16 bytes at a time and this
potentially leads to OOB read for some buffers
allocated on stack using ALLOC() calls. In order to
avoid these OOB reads, ALLOC() now allocates 16 additional bytes.
Bug: 191352053
Test: poc in bug description
Test: atest VtsHalMediaC2V1_0TargetAudioDecTest
Test: atest VtsHalMediaC2V1_0TargetAudioEncTest
Change-Id: I4da2840844d60f251dd7a222f51d508e4eb8749f
(cherry picked from commit 878bdeb38043407869c684fb73708b04e8fe0ce4)
|
|
Test: make
Change-Id: I719a5daa80f9e79d42e66cc66306fdbad4dbe3c1
|
|
Reported by toto.
|
|
Test: make
Change-Id: I3e5232d6c6d250c69abfa71482ac91e30c1933b6
|
|
There is a small typo in celt/fixed_generic.h.
Should read `nearest` rather than `neareast`.
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
Test: make
Change-Id: I995f04a04951ca22916a7b418afdd8ba59bcd130
|
|
Tested on:
- Linux/x86* with gcc
- Android armv7 arm64 x86 x86_64 with clang
- Windows x86 x86_64 with Visual Studio 2017
- Windows x86 x86_64 with MinGW
- macOS x86_64 with clang
- iOS arm64 x86_64 with clang
Co-authored by: Nirbheek Chauhan <nirbheek@centricular.com>
https://gitlab.xiph.org/xiph/opus/-/merge_requests/13
|
|
Bug: 167721530
Test: atest android.mediav2.cts
Test: run vts -m VtsHalMediaC2V1_0TargetAudioDecTest
Test: run vts -m VtsHalMediaC2V1_0TargetAudioEncTest
Change-Id: Id6900a9d5084fb6ae840f44a2b9133f95e1b96bc
|
|
This merges tag v1.3 from upstream-master and establishes history
between upstream-master and master
This better positions the code for automating
future pulls from the upstream repository.
Bug: 167721530
Test: builds
Change-Id: Ieb361bade32dd21ab7dadbb74b79d3ee3c13ec1a
|
|
Specify the precision as float to avoid truncating from double.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
_WIN32 is defined on all Windows platforms by every compiler that
targets Windows. We do not need WIN32 at all.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
Resolves https://github.com/xiph/opus/pull/104
|
|
This broke 5 years ago in 43120f00758219a784f952754f33b9788a8d731b
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
The autotools build doesn't set OPUS_HAVE_RTCD for arm targets,
assuming all the supported intrinsics will work on the runtime
cpu.
The cmake build however defines this by default when the neon
extension is available on the target. On Linux, the runtime
cpu detection reads /proc/cpuinfo, so removing stdio.h from
celt/os_support.h meant that the cmake build for arm targets
failed.
We don't currently have ci runs for that configuration, so
this only became apparent through manual testing.
Signed-off-by: Marcus Asteborg <maastebo@microsoft.com>
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
This lighter-weight intrinsics header is available starting
with Microsoft Visual Studio 2017, so the previous change
to allow this header failed when building with Visual
Studio 2015.
Restores the appveyor continuous integration build.
|
|
remove usage of stdio.h in production code
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
in tests.
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
Broken by earlier ARM optimizations.
|
|
Reported in https://github.com/xiph/opus/issues/108
|
|
|
|
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
Bug: 63932386
Test: - verified builds for arm*/x86*
- checked functionality using an emulator and stagefright
Change-Id: I10c4b267be1c846d8992e3c5f6d2576c2cb258a9
Signed-off-by: Felicia Lim <flim@google.com>
|
|
Addresses the rest of https://github.com/xiph/opus/pull/79
|
|
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
As suggested in https://github.com/xiph/opus/pull/83
|
|
The error was:
c:\projects\opus\celt\celt_encoder.c(1019): fatal error C1001: An internal error has occurred in the compiler. [C:\projects\opus\win32\VS2015\opus.vcxproj]
(compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 255)
To work around this problem, try simplifying or changing the program near the locations listed above.
Please choose the Technical Support command on the Visual C++
Help menu, or open the Technical Support help file for more information
Internal Compiler Error in C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\x86_amd64\CL.exe. You will be prompted to send an error report to Microsoft later.
|
|
Didn't cause any problem, but still good to fix. Reported by
keithchugg on github.
|
|
clang -Wcast-align warnings with ambisonics enabled
clang -Wnull-pointer-arithmetic warnings in test_opus_api.c
gcc -Wimplicit-fallthrough warnings on arm
msvc warning C4244 in celt_encoder.c with fixed point
|
|
|
|
Fixes test_opus_projection failure under ubsan, due to clz(0).
|
|
|
|
NaNs should be filtered at the Opus layer, so if there are any in the CELT
encoder, then it's likely something went horribly wrong (e.g. corrupted state).
In that case, better abort than have something bad happen.
|
|
|
|
|
|
|
|
Enables "safes" assertions even with ENABLE_ASSERTIONS isn't set
|
|
Reported by daddesio in #opus
|
|
|
|
This improves cases where a whole region is dominated by a handful of tones
|
|
|
|
|
|
Also adds the error terms for band 0 that were previously omitted
|
|
That corresponds to the fundamental for the shortest pitch period allowed
|
|
Fixes a warning from PVS-Studio. This was a cut-and-paste error
from the stanza above and had no effect.
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
Addresses issue https://github.com/xiph/opus/issues/54
|
|
Addresses issue https://github.com/xiph/opus/issues/58
|