diff options
| author | Mark Harris <mark.hsj@gmail.com> | 2017-02-20 19:51:40 -0800 |
|---|---|---|
| committer | Mark Harris <mark.hsj@gmail.com> | 2017-02-26 19:10:45 -0800 |
| commit | d6d70371e85ec83307f6df0e067d353daa8e6f33 (patch) | |
| tree | 9e118ef0267e2e0734cc9db4c5bbd6016aa0e089 /celt/x86 | |
| parent | 8056706f48880bbf0bb7ee842f1067b85f613353 (diff) | |
| download | libopus-d6d70371e85ec83307f6df0e067d353daa8e6f33.tar.gz | |
Fix compiler warnings
- celt/modes.c:430:14: warning: cast from 'const unsigned char *' to
'opus_int16 *' increases required alignment from 1 to 2 [-Wcast-align]
- 'C[0][1]' may be used uninitialized [-Wmaybe-uninitialized]
- Unused variable/parameter
- Value stored is never read
- MSVC warnings about "possible loss of data" due to type conversions
- MSVC warning C4146: unary minus operator applied to unsigned type
- silk/NLSF_del_dec_quant.c:137:20: warning: array subscript is above
array bounds [-Warray-bounds] (gcc -O3 false positive)
- src/mlp_train.h:39:20: warning: function declaration isn't a prototype
[-Wstrict-prototypes]
- Remove SMALL_FOOTPRINT code from SSE 4.1 FIR implementation, matching
the C implementation.
The clang -Wcast-align warnings with SSE intrinsics are a known
clang issue: https://llvm.org/bugs/show_bug.cgi?id=20670
Diffstat (limited to 'celt/x86')
| -rw-r--r-- | celt/x86/celt_lpc_sse.c | 12 | ||||
| -rw-r--r-- | celt/x86/vq_sse2.c | 1 |
2 files changed, 0 insertions, 13 deletions
diff --git a/celt/x86/celt_lpc_sse.c b/celt/x86/celt_lpc_sse.c index 12a9b0e5..54785688 100644 --- a/celt/x86/celt_lpc_sse.c +++ b/celt/x86/celt_lpc_sse.c @@ -57,17 +57,6 @@ void celt_fir_sse4_1(const opus_val16 *x, ALLOC(rnum, ord, opus_val16); for(i=0;i<ord;i++) rnum[i] = num[ord-i-1]; -#ifdef SMALL_FOOTPRINT - for (i=0;i<N;i++) - { - opus_val32 sum = SHL32(EXTEND32(x[i]), SIG_SHIFT); - for (j=0;j<ord;j++) - { - sum = MAC16_16(sum,rnum[j],x[i+j-ord]); - } - y[i] = SATURATE16(PSHR32(sum, SIG_SHIFT)); - } -#else noA = EXTEND32(1) << SIG_SHIFT >> 1; vecNoA = _mm_set_epi32(noA, noA, noA, noA); @@ -94,7 +83,6 @@ void celt_fir_sse4_1(const opus_val16 *x, y[i] = SATURATE16(ADD32(EXTEND32(x[i]), PSHR32(sum, SIG_SHIFT))); } -#endif RESTORE_STACK; } diff --git a/celt/x86/vq_sse2.c b/celt/x86/vq_sse2.c index c82d7e24..6a317703 100644 --- a/celt/x86/vq_sse2.c +++ b/celt/x86/vq_sse2.c @@ -155,7 +155,6 @@ opus_val16 op_pvq_search_sse2(celt_norm *_X, int *iy, int K, int N, int arch) __m128 max, max2; __m128i count; __m128i pos; - best_id = 0; /* The squared magnitude term gets added anyway, so we might as well add it outside the loop */ yy = ADD16(yy, 1); |