diff options
author | zpencer <spencerfang@google.com> | 2018-01-26 16:51:45 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-01-26 16:51:45 -0800 |
commit | 0465bb5aeba7ec6aebd3f3a2a8149c3be8b761c9 (patch) | |
tree | 093cc38492aa02a32882e11213cd8fb7f4684787 /testing | |
parent | af936919f3a92debd67664c5d583a185c0eea1f6 (diff) | |
download | grpc-grpc-java-0465bb5aeba7ec6aebd3f3a2a8149c3be8b761c9.tar.gz |
core,testing: deprecate passing ServerCall to StatsTraceContext (#3912)
Instead, pass a ServerCallInfo object containing the interesting bits
of info. This lets us modify the call handler for binary logging, but
still provide the original info to the StatsTraceContext API.
Diffstat (limited to 'testing')
-rw-r--r-- | testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java | 2 | ||||
-rw-r--r-- | testing/src/main/java/io/grpc/internal/testing/TestServerStreamTracer.java | 13 |
2 files changed, 7 insertions, 8 deletions
diff --git a/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java b/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java index 05ec5f4ad..0af6b761a 100644 --- a/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java +++ b/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java @@ -581,7 +581,7 @@ public abstract class AbstractTransportTest { any(CallOptions.class), any(Metadata.class)); assertSame(shutdownReason, clientStreamTracer1.getStatus()); // Assert no interactions - assertNull(serverStreamTracer1.getServerCall()); + assertNull(serverStreamTracer1.getServerCallInfo()); } @Test diff --git a/testing/src/main/java/io/grpc/internal/testing/TestServerStreamTracer.java b/testing/src/main/java/io/grpc/internal/testing/TestServerStreamTracer.java index d8e3a3aa5..a7c347a47 100644 --- a/testing/src/main/java/io/grpc/internal/testing/TestServerStreamTracer.java +++ b/testing/src/main/java/io/grpc/internal/testing/TestServerStreamTracer.java @@ -16,7 +16,6 @@ package io.grpc.internal.testing; -import io.grpc.ServerCall; import io.grpc.ServerStreamTracer; import io.grpc.Status; import java.util.concurrent.TimeUnit; @@ -27,8 +26,8 @@ import java.util.concurrent.atomic.AtomicReference; */ public class TestServerStreamTracer extends ServerStreamTracer implements TestStreamTracer { private final TestBaseStreamTracer delegate = new TestBaseStreamTracer(); - protected final AtomicReference<ServerCall<?,?>> serverCall = - new AtomicReference<ServerCall<?,?>>(); + protected final AtomicReference<ServerCallInfo<?, ?>> serverCallInfo = + new AtomicReference<ServerCallInfo<?, ?>>(); @Override public void await() throws InterruptedException { @@ -43,8 +42,8 @@ public class TestServerStreamTracer extends ServerStreamTracer implements TestSt /** * Returns the ServerCall passed to {@link ServerStreamTracer#serverCallStarted}. */ - public ServerCall<?, ?> getServerCall() { - return serverCall.get(); + public ServerCallInfo<?, ?> getServerCallInfo() { + return serverCallInfo.get(); } @Override @@ -145,8 +144,8 @@ public class TestServerStreamTracer extends ServerStreamTracer implements TestSt } @Override - public void serverCallStarted(ServerCall<?, ?> call) { - if (!serverCall.compareAndSet(null, call) && delegate.failDuplicateCallbacks.get()) { + public void serverCallStarted(ServerCallInfo<?, ?> callInfo) { + if (!serverCallInfo.compareAndSet(null, callInfo) && delegate.failDuplicateCallbacks.get()) { throw new AssertionError("serverCallStarted called more than once"); } } |