aboutsummaryrefslogtreecommitdiff
path: root/testing
diff options
context:
space:
mode:
authorKun Zhang <zhangkun83@users.noreply.github.com>2018-04-12 09:05:48 -0700
committerGitHub <noreply@github.com>2018-04-12 09:05:48 -0700
commit3f63cd0ad49c013982152eaf73cab12fe3d9dade (patch)
tree2576598860953a3b964f3816c3704eb7431122b0 /testing
parent7c46bd93994175545d510e4a5ef308755c6a204f (diff)
downloadgrpc-grpc-java-3f63cd0ad49c013982152eaf73cab12fe3d9dade.tar.gz
core: always call StreamTracer.streamClosed() when stream is officially closed. (#4331)
Previously StreamTracer.streamClosed() is called in ServerStream.close(), but it is not exactly when the stream is officially closed. ServerStreamListener.closed() is guaranteed to be called and it is the official end of the stream.
Diffstat (limited to 'testing')
-rw-r--r--testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java b/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java
index d69d2d527..5caca3712 100644
--- a/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java
+++ b/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java
@@ -776,10 +776,10 @@ public abstract class AbstractTransportTest {
trailers.put(asciiKey, "dupvalue");
trailers.put(binaryKey, "äbinarytrailers");
serverStream.close(status, trailers);
- assertSame(status, serverStreamTracer1.getStatus());
assertNull(serverStreamTracer1.nextInboundEvent());
assertNull(serverStreamTracer1.nextOutboundEvent());
assertCodeEquals(Status.OK, serverStreamListener.status.get(TIMEOUT_MS, TimeUnit.MILLISECONDS));
+ assertSame(status, serverStreamTracer1.getStatus());
Status clientStreamStatus = clientStreamListener.status.get(TIMEOUT_MS, TimeUnit.MILLISECONDS);
Metadata clientStreamTrailers =
clientStreamListener.trailers.get(TIMEOUT_MS, TimeUnit.MILLISECONDS);