diff options
author | zpencer <spencerfang@google.com> | 2018-09-04 16:52:01 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-09-04 16:52:01 -0700 |
commit | 4d366ce978683bab49660134a266afff8102fea6 (patch) | |
tree | af13e43aa5b03eafc9616564c244c132ca5ea044 /okhttp | |
parent | f8274c4e7c92733574a16733bc5f725898772f75 (diff) | |
download | grpc-grpc-java-4d366ce978683bab49660134a266afff8102fea6.tar.gz |
all: move Channelz to io.grpc as InternalChannelz (#4797)
This is an API used to coordinate across packages and must live in
`io.grpc`.
Prepending `Internal` makes it easier to detect and hide this class
from public visibility when using certain build tools.
fixes #4796
Diffstat (limited to 'okhttp')
4 files changed, 14 insertions, 14 deletions
diff --git a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java index 27c60a809..a610ede2a 100644 --- a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java +++ b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java @@ -34,6 +34,9 @@ import io.grpc.Attributes; import io.grpc.CallCredentials; import io.grpc.CallOptions; import io.grpc.Grpc; +import io.grpc.InternalChannelz; +import io.grpc.InternalChannelz.SocketStats; +import io.grpc.LogId; import io.grpc.Metadata; import io.grpc.MethodDescriptor; import io.grpc.MethodDescriptor.MethodType; @@ -41,15 +44,12 @@ import io.grpc.SecurityLevel; import io.grpc.Status; import io.grpc.Status.Code; import io.grpc.StatusException; -import io.grpc.internal.Channelz; -import io.grpc.internal.Channelz.SocketStats; import io.grpc.internal.ClientStreamListener.RpcProgress; import io.grpc.internal.ConnectionClientTransport; import io.grpc.internal.GrpcUtil; import io.grpc.internal.Http2Ping; import io.grpc.internal.KeepAliveManager; import io.grpc.internal.KeepAliveManager.ClientKeepAlivePinger; -import io.grpc.internal.LogId; import io.grpc.internal.ProxyParameters; import io.grpc.internal.SerializingExecutor; import io.grpc.internal.SharedResourceHolder; @@ -192,7 +192,7 @@ class OkHttpClientTransport implements ConnectionClientTransport, TransportExcep @GuardedBy("lock") private final TransportTracer transportTracer; @GuardedBy("lock") - private Channelz.Security securityInfo; + private InternalChannelz.Security securityInfo; @VisibleForTesting @Nullable @@ -505,7 +505,7 @@ class OkHttpClientTransport implements ConnectionClientTransport, TransportExcep maxConcurrentStreams = Integer.MAX_VALUE; startPendingStreams(); if (sslSession != null) { - securityInfo = new Channelz.Security(new Channelz.Tls(sslSession)); + securityInfo = new InternalChannelz.Security(new InternalChannelz.Tls(sslSession)); } } @@ -930,7 +930,7 @@ class OkHttpClientTransport implements ConnectionClientTransport, TransportExcep transportTracer.getStats(), /*local=*/ null, /*remote=*/ null, - new Channelz.SocketOptions.Builder().build(), + new InternalChannelz.SocketOptions.Builder().build(), /*security=*/ null)); } else { ret.set(new SocketStats( diff --git a/okhttp/src/main/java/io/grpc/okhttp/Utils.java b/okhttp/src/main/java/io/grpc/okhttp/Utils.java index 8c487c3ff..6a0dcd707 100644 --- a/okhttp/src/main/java/io/grpc/okhttp/Utils.java +++ b/okhttp/src/main/java/io/grpc/okhttp/Utils.java @@ -17,9 +17,9 @@ package io.grpc.okhttp; import com.google.common.base.Preconditions; +import io.grpc.InternalChannelz; import io.grpc.InternalMetadata; import io.grpc.Metadata; -import io.grpc.internal.Channelz; import io.grpc.internal.TransportFrameUtil; import io.grpc.okhttp.internal.CipherSuite; import io.grpc.okhttp.internal.ConnectionSpec; @@ -88,11 +88,11 @@ class Utils { /** * Attempts to capture all known socket options and return the results as a - * {@link Channelz.SocketOptions}. If getting a socket option threw an exception, + * {@link InternalChannelz.SocketOptions}. If getting a socket option threw an exception, * log the error to the logger and report the value as an error in the response. */ - static Channelz.SocketOptions getSocketOptions(Socket socket) { - Channelz.SocketOptions.Builder builder = new Channelz.SocketOptions.Builder(); + static InternalChannelz.SocketOptions getSocketOptions(Socket socket) { + InternalChannelz.SocketOptions.Builder builder = new InternalChannelz.SocketOptions.Builder(); try { builder.setSocketOptionLingerSeconds(socket.getSoLinger()); } catch (SocketException e) { diff --git a/okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java b/okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java index 9b85d8406..130c03049 100644 --- a/okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java +++ b/okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java @@ -55,6 +55,9 @@ import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.MoreExecutors; import com.google.common.util.concurrent.SettableFuture; import io.grpc.CallOptions; +import io.grpc.Instrumented; +import io.grpc.InternalChannelz.SocketStats; +import io.grpc.InternalChannelz.TransportStats; import io.grpc.InternalStatus; import io.grpc.Metadata; import io.grpc.MethodDescriptor; @@ -63,12 +66,9 @@ import io.grpc.Status; import io.grpc.Status.Code; import io.grpc.StatusException; import io.grpc.internal.AbstractStream; -import io.grpc.internal.Channelz.SocketStats; -import io.grpc.internal.Channelz.TransportStats; import io.grpc.internal.ClientStreamListener; import io.grpc.internal.ClientTransport; import io.grpc.internal.GrpcUtil; -import io.grpc.internal.Instrumented; import io.grpc.internal.ManagedClientTransport; import io.grpc.internal.ProxyParameters; import io.grpc.internal.TransportTracer; diff --git a/okhttp/src/test/java/io/grpc/okhttp/UtilsTest.java b/okhttp/src/test/java/io/grpc/okhttp/UtilsTest.java index 5ce5ea749..cdaf98c57 100644 --- a/okhttp/src/test/java/io/grpc/okhttp/UtilsTest.java +++ b/okhttp/src/test/java/io/grpc/okhttp/UtilsTest.java @@ -19,7 +19,7 @@ package io.grpc.okhttp; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; -import io.grpc.internal.Channelz.SocketOptions; +import io.grpc.InternalChannelz.SocketOptions; import io.grpc.okhttp.internal.CipherSuite; import io.grpc.okhttp.internal.ConnectionSpec; import io.grpc.okhttp.internal.TlsVersion; |