aboutsummaryrefslogtreecommitdiff
path: root/cronet
diff options
context:
space:
mode:
authorEric Gribkoff <ericgribkoff@google.com>2018-03-15 19:09:19 -0700
committerGitHub <noreply@github.com>2018-03-15 19:09:19 -0700
commit5e8b8c2bee565ac9f897e0e5b0242216f51e1f15 (patch)
treeae1989fb7e1f16b96b8ef100badfa5ca37ab524f /cronet
parent37cd0427d06312c43cd995f17ae06c34d12df3ec (diff)
downloadgrpc-grpc-java-5e8b8c2bee565ac9f897e0e5b0242216f51e1f15.tar.gz
cronet: delay cast to ExperimentalCronetEngine (#4230)
Diffstat (limited to 'cronet')
-rw-r--r--cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java21
1 files changed, 13 insertions, 8 deletions
diff --git a/cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java b/cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java
index 005329de2..9cea2f8f7 100644
--- a/cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java
+++ b/cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java
@@ -56,7 +56,7 @@ public final class CronetChannelBuilder extends
/** Creates a new builder for the given server host, port and CronetEngine. */
public static CronetChannelBuilder forAddress(String host, int port, CronetEngine cronetEngine) {
Preconditions.checkNotNull(cronetEngine, "cronetEngine");
- return new CronetChannelBuilder(host, port, (ExperimentalCronetEngine) cronetEngine);
+ return new CronetChannelBuilder(host, port, cronetEngine);
}
/**
@@ -73,7 +73,7 @@ public final class CronetChannelBuilder extends
throw new UnsupportedOperationException("call forAddress(String, int, CronetEngine) instead");
}
- private final ExperimentalCronetEngine cronetEngine;
+ private final CronetEngine cronetEngine;
private boolean alwaysUsePut = false;
@@ -84,7 +84,7 @@ public final class CronetChannelBuilder extends
private boolean trafficStatsUidSet;
private int trafficStatsUid;
- private CronetChannelBuilder(String host, int port, ExperimentalCronetEngine cronetEngine) {
+ private CronetChannelBuilder(String host, int port, CronetEngine cronetEngine) {
super(
InetSocketAddress.createUnresolved(host, port),
GrpcUtil.authorityFromHostAndPort(host, port));
@@ -224,14 +224,14 @@ public final class CronetChannelBuilder extends
* StreamBuilderFactory impl that applies TrafficStats tags to stream builders that are produced.
*/
private static class TaggingStreamFactory extends StreamBuilderFactory {
- private final ExperimentalCronetEngine cronetEngine;
+ private final CronetEngine cronetEngine;
private final boolean trafficStatsTagSet;
private final int trafficStatsTag;
private final boolean trafficStatsUidSet;
private final int trafficStatsUid;
TaggingStreamFactory(
- ExperimentalCronetEngine cronetEngine,
+ CronetEngine cronetEngine,
boolean trafficStatsTagSet,
int trafficStatsTag,
boolean trafficStatsUidSet,
@@ -247,9 +247,14 @@ public final class CronetChannelBuilder extends
public BidirectionalStream.Builder newBidirectionalStreamBuilder(
String url, BidirectionalStream.Callback callback, Executor executor) {
ExperimentalBidirectionalStream.Builder builder =
- cronetEngine.newBidirectionalStreamBuilder(url, callback, executor);
- if (trafficStatsTagSet) builder.setTrafficStatsTag(trafficStatsTag);
- if (trafficStatsUidSet) builder.setTrafficStatsUid(trafficStatsUid);
+ ((ExperimentalCronetEngine) cronetEngine)
+ .newBidirectionalStreamBuilder(url, callback, executor);
+ if (trafficStatsTagSet) {
+ builder.setTrafficStatsTag(trafficStatsTag);
+ }
+ if (trafficStatsUidSet) {
+ builder.setTrafficStatsUid(trafficStatsUid);
+ }
return builder;
}
}