diff options
author | Eric Anderson <ejona@google.com> | 2016-12-08 10:19:08 -0800 |
---|---|---|
committer | Eric Anderson <ejona@google.com> | 2016-12-08 10:33:31 -0800 |
commit | cfb6bd0fe23fc88c6f28bc773835dd8c61cad59d (patch) | |
tree | f2695b95aaba3ef09267ffd77c68eb5cc3541f63 /context | |
parent | 21bca9a475a7b9a0755e0c83dbce9b17786db57f (diff) | |
download | grpc-grpc-java-cfb6bd0fe23fc88c6f28bc773835dd8c61cad59d.tar.gz |
context: Fix ErrorProne ClassNewInstance
http://errorprone.info/bugpattern/ClassNewInstance
Diffstat (limited to 'context')
-rw-r--r-- | context/src/main/java/io/grpc/Context.java | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/context/src/main/java/io/grpc/Context.java b/context/src/main/java/io/grpc/Context.java index 68db7521c..db7aaf7ab 100644 --- a/context/src/main/java/io/grpc/Context.java +++ b/context/src/main/java/io/grpc/Context.java @@ -128,13 +128,11 @@ public class Context { } try { Class<?> clazz = Class.forName("io.grpc.ContextStorageOverride"); - storage = (Storage) clazz.newInstance(); + storage = (Storage) clazz.getConstructor().newInstance(); return storage; } catch (ClassNotFoundException e) { log.log(Level.FINE, "Storage override doesn't exist. Using default.", e); - } catch (InstantiationException e) { - throw new RuntimeException("Failed to initialize Storage implementation", e); - } catch (IllegalAccessException e) { + } catch (Exception e) { throw new RuntimeException("Failed to initialize Storage implementation", e); } storage = new ThreadLocalContextStorage(); |