diff options
author | Eric Anderson <ejona@google.com> | 2018-09-08 09:41:12 -0700 |
---|---|---|
committer | Eric Anderson <ejona@google.com> | 2018-09-10 17:45:20 -0700 |
commit | 98630f187018a0f765f52953a7bab7eb2a1ee534 (patch) | |
tree | 85ba3ea70fc5e24cd79ada93df3ae4ed1fcddea7 | |
parent | 1da3133fdf073b9a045e7f1c8616302c479b146f (diff) | |
download | grpc-grpc-java-98630f187018a0f765f52953a7bab7eb2a1ee534.tar.gz |
netty,okhttp: Enable TransportTest.flowControlPushBack
It appears to be stable now. Ran for 1000s of times. I do see some
general flakiness in TransportTest, but it applies to the tests in
general and isn't specific to this one test. It is:
```
org.mockito.exceptions.verification.WantedButNotInvoked:
Wanted but not invoked:
listener.transportReady();
-> at io.grpc.internal.testing.AbstractTransportTest.startTransport(AbstractTransportTest.java:1815)
Actually, there were zero interactions with this mock.
```
This flake is not seen often because it occurs less frequently when
running all the tests (~.1% vs 1%). One of the early tests must warm
something up to make it less likely.
-rw-r--r-- | netty/src/test/java/io/grpc/netty/NettyTransportTest.java | 7 | ||||
-rw-r--r-- | okhttp/src/test/java/io/grpc/okhttp/OkHttpTransportTest.java | 8 |
2 files changed, 0 insertions, 15 deletions
diff --git a/netty/src/test/java/io/grpc/netty/NettyTransportTest.java b/netty/src/test/java/io/grpc/netty/NettyTransportTest.java index cb5dee943..1aa4c12f2 100644 --- a/netty/src/test/java/io/grpc/netty/NettyTransportTest.java +++ b/netty/src/test/java/io/grpc/netty/NettyTransportTest.java @@ -26,8 +26,6 @@ import java.net.InetSocketAddress; import java.util.List; import java.util.concurrent.TimeUnit; import org.junit.After; -import org.junit.Ignore; -import org.junit.Test; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; @@ -99,9 +97,4 @@ public class NettyTransportTest extends AbstractTransportTest { new ClientTransportFactory.ClientTransportOptions() .setAuthority(testAuthority(server))); } - - @Test - @Ignore("flaky") - @Override - public void flowControlPushBack() {} } diff --git a/okhttp/src/test/java/io/grpc/okhttp/OkHttpTransportTest.java b/okhttp/src/test/java/io/grpc/okhttp/OkHttpTransportTest.java index 9b67450be..97a686d39 100644 --- a/okhttp/src/test/java/io/grpc/okhttp/OkHttpTransportTest.java +++ b/okhttp/src/test/java/io/grpc/okhttp/OkHttpTransportTest.java @@ -28,8 +28,6 @@ import java.net.InetSocketAddress; import java.util.List; import java.util.concurrent.TimeUnit; import org.junit.After; -import org.junit.Ignore; -import org.junit.Test; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; @@ -96,12 +94,6 @@ public class OkHttpTransportTest extends AbstractTransportTest { return fakeClock.getTicker().read(); } - // TODO(ejona): Flaky/Broken - @Test - @Ignore - @Override - public void flowControlPushBack() {} - @Override protected boolean haveTransportTracer() { return true; |