diff options
| author | Samuel Benzaquen <sbenza@google.com> | 2023-01-10 10:53:09 -0500 |
|---|---|---|
| committer | Michael Stapelberg <stapelberg@google.com> | 2023-01-12 08:45:15 +0000 |
| commit | 31a59208116ee2cacd5b3e4f64cf17ad733e18db (patch) | |
| tree | 4baee0bbe8f9202a883cb0ba9310ee691da4aa56 | |
| parent | a8d446d548e4cfda41570959bd99c90365c2b995 (diff) | |
| download | golang-protobuf-31a59208116ee2cacd5b3e4f64cf17ad733e18db.tar.gz | |
protobuf: remove the check for reserved field numbers.
Field numbers in the reserved range are semantically valid,
although the protocol buffer compiler may reject attempts to
define fields in this range.
Change-Id: Ib939ed5f4fef09b29047b509829b2f01494bfb6a
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/461238
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Michael Stapelberg <stapelberg@google.com>
| -rw-r--r-- | encoding/protowire/wire.go | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/encoding/protowire/wire.go b/encoding/protowire/wire.go index ce57f57e..583d2941 100644 --- a/encoding/protowire/wire.go +++ b/encoding/protowire/wire.go @@ -29,12 +29,8 @@ const ( ) // IsValid reports whether the field number is semantically valid. -// -// Note that while numbers within the reserved range are semantically invalid, -// they are syntactically valid in the wire format. -// Implementations may treat records with reserved field numbers as unknown. func (n Number) IsValid() bool { - return MinValidNumber <= n && n < FirstReservedNumber || LastReservedNumber < n && n <= MaxValidNumber + return MinValidNumber <= n && n <= MaxValidNumber } // Type represents the wire type. |