summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjcater <jcater@google.com>2018-05-02 09:08:52 -0700
committerIvan Gavrilovic <gavra@google.com>2018-05-04 10:41:44 +0100
commit6c7f67fe112e0eae9a41b74bf37ced67a88516fc (patch)
treeabcca77c7d825a4f70ff1e280c7497355c0985d2
parentac50274742dc9431da2669348102ad5f0cf200aa (diff)
downloaddesugar-6c7f67fe112e0eae9a41b74bf37ced67a88516fc.tar.gz
Clean up code that directly imports nested classes like Builder, Entry, etc.
PiperOrigin-RevId: 195100670 GitOrigin-RevId: 94b8702db5f9a905337aca74bfc2e7c436bf33ec Change-Id: Iea45a0d018d49a43181c1e357721d0b552bea777
-rw-r--r--java/com/google/devtools/common/options/OptionValueDescription.java14
-rw-r--r--java/com/google/devtools/common/options/OptionsBase.java3
-rw-r--r--java/com/google/devtools/common/options/OptionsParser.java5
3 files changed, 10 insertions, 12 deletions
diff --git a/java/com/google/devtools/common/options/OptionValueDescription.java b/java/com/google/devtools/common/options/OptionValueDescription.java
index f52e8a5..11ad7fe 100644
--- a/java/com/google/devtools/common/options/OptionValueDescription.java
+++ b/java/com/google/devtools/common/options/OptionValueDescription.java
@@ -22,7 +22,7 @@ import com.google.devtools.common.options.OptionsParser.ConstructionException;
import java.util.Collection;
import java.util.Comparator;
import java.util.List;
-import java.util.Map.Entry;
+import java.util.Map;
import java.util.stream.Collectors;
import javax.annotation.Nullable;
@@ -276,8 +276,8 @@ public abstract class OptionValueDescription {
.asMap()
.entrySet()
.stream()
- .sorted(Comparator.comparing(Entry::getKey))
- .map(Entry::getValue)
+ .sorted(Comparator.comparing(Map.Entry::getKey))
+ .map(Map.Entry::getValue)
.flatMap(Collection::stream)
.map(ParsedOptionDescription::getSource)
.distinct()
@@ -292,8 +292,8 @@ public abstract class OptionValueDescription {
.asMap()
.entrySet()
.stream()
- .sorted(Comparator.comparing(Entry::getKey))
- .map(Entry::getValue)
+ .sorted(Comparator.comparing(Map.Entry::getKey))
+ .map(Map.Entry::getValue)
.flatMap(Collection::stream)
.collect(Collectors.toList());
}
@@ -320,8 +320,8 @@ public abstract class OptionValueDescription {
.asMap()
.entrySet()
.stream()
- .sorted(Comparator.comparing(Entry::getKey))
- .map(Entry::getValue)
+ .sorted(Comparator.comparing(Map.Entry::getKey))
+ .map(Map.Entry::getValue)
.flatMap(Collection::stream)
// Only provide the options that aren't implied elsewhere.
.filter(optionDesc -> optionDesc.getImplicitDependent() == null)
diff --git a/java/com/google/devtools/common/options/OptionsBase.java b/java/com/google/devtools/common/options/OptionsBase.java
index 6b9f2f1..9496c65 100644
--- a/java/com/google/devtools/common/options/OptionsBase.java
+++ b/java/com/google/devtools/common/options/OptionsBase.java
@@ -20,7 +20,6 @@ import java.lang.reflect.Field;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
-import java.util.Map.Entry;
/**
* Base class for all options classes. Extend this class, adding public instance fields annotated
@@ -93,7 +92,7 @@ public abstract class OptionsBase {
public final String cacheKey() {
StringBuilder result = new StringBuilder(getClass().getName()).append("{");
- for (Entry<String, Object> entry : asMap().entrySet()) {
+ for (Map.Entry<String, Object> entry : asMap().entrySet()) {
result.append(entry.getKey()).append("=");
Object value = entry.getValue();
diff --git a/java/com/google/devtools/common/options/OptionsParser.java b/java/com/google/devtools/common/options/OptionsParser.java
index e75f0e1..6f1d7b6 100644
--- a/java/com/google/devtools/common/options/OptionsParser.java
+++ b/java/com/google/devtools/common/options/OptionsParser.java
@@ -33,7 +33,6 @@ import java.util.LinkedHashMap;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
-import java.util.Map.Entry;
import java.util.Set;
import java.util.function.Consumer;
import java.util.function.Function;
@@ -299,7 +298,7 @@ public class OptionsParser implements OptionsProvider {
getOptionsSortedByCategory();
ImmutableMap<OptionDocumentationCategory, String> optionCategoryDescriptions =
OptionFilterDescriptions.getOptionCategoriesEnumDescription(productName);
- for (Entry<OptionDocumentationCategory, List<OptionDefinition>> e :
+ for (Map.Entry<OptionDocumentationCategory, List<OptionDefinition>> e :
optionsByCategory.entrySet()) {
String categoryDescription = optionCategoryDescriptions.get(e.getKey());
List<OptionDefinition> categorizedOptionList = e.getValue();
@@ -463,7 +462,7 @@ public class OptionsParser implements OptionsProvider {
ImmutableMap<OptionDocumentationCategory, String> optionCategoryDescriptions =
OptionFilterDescriptions.getOptionCategoriesEnumDescription(productName);
- for (Entry<OptionDocumentationCategory, List<OptionDefinition>> e :
+ for (Map.Entry<OptionDocumentationCategory, List<OptionDefinition>> e :
optionsByCategory.entrySet()) {
desc.append("<dl>");
String categoryDescription = optionCategoryDescriptions.get(e.getKey());