summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdem Derinel <derinel@google.com>2024-03-07 11:29:44 +0000
committerCopybara-Service <copybara-worker@google.com>2024-03-07 03:37:11 -0800
commit574631531468a43b65202a7a276b81fca41c650e (patch)
treef11ecae27af6ce8a289d9cdc28c024649cb76712
parent162718bca7c7f47ca30b0684bbd0a6ffb3c6fdd4 (diff)
downloadwebview_support_interfaces-574631531468a43b65202a7a276b81fca41c650e.tar.gz
Reland "[WebView][WebAuthn] Introduce WebSettings.setWebAuthnSupport"
With the reland of crrev.com/c/5327926, this should be reland to safe. No changes wrt the original CL. This is a reland of commit 991e4f9f43589d8451c10475ba39f4054076d560 Original change's description: > [WebView][WebAuthn] Introduce WebSettings.setWebAuthnSupport > > The support is per WebView. Hence, we cache the support per WebContents. > When the WebContents of a WebView change, we update the cache. > > Test method: > 1 - androidx does not have the API yet. Thus, I modified the > WebSettingsCompat.setAlgorithmicDarkeningAllowed to call the new > setWebAuthnSupport API. Then I used the API in the test app. > 2 - Used the custom GMSCore which includes the ResultReceiver changes. > > Demo: https://photos.app.goo.gl/bsrJtCuAMM2Ee9Je8 > In the demo you see two WebViews within a single app. The first has > WebAuthn disabled; the second is in app mode. > > Bug: b/41483780, b/316886235 > Change-Id: If3eae1634044cc117dac435d8bd823194cb47e5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273159 > Reviewed-by: Richard (Torne) Coles <torne@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Commit-Queue: Adem Derinel <derinel@google.com> > Cr-Commit-Position: refs/heads/main@{#1265745} Bug: b/41483780, b/316886235 Change-Id: I95de7a1e05e38f15021b73d062abb8504f60fc66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5349152 Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Adem Derinel <derinel@google.com> Cr-Commit-Position: refs/heads/main@{#1269507} NOKEYCHECK=True GitOrigin-RevId: 916b2555fb5e060d9e53f472c655ea748b713b9d
-rw-r--r--src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java b/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java
index 4c85262..f3a27ce 100644
--- a/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java
+++ b/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java
@@ -55,16 +55,16 @@ public interface WebSettingsBoundaryInterface {
int getForceDarkBehavior();
@Retention(RetentionPolicy.SOURCE)
- @interface WebAuthnSupport {
+ @interface WebauthnSupport {
int NONE = 0;
int APP = 1;
int BROWSER = 2;
}
- void setWebAuthnSupport(@WebAuthnSupport int support);
+ void setWebauthnSupport(@WebauthnSupport int support);
- @WebAuthnSupport
- int getWebAuthnSupport();
+ @WebauthnSupport
+ int getWebauthnSupport();
void setRequestedWithHeaderOriginAllowList(Set<String> allowedOriginRules);