diff options
| author | TreeHugger Robot <treehugger-gerrit@google.com> | 2021-01-07 12:21:05 +0000 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2021-01-07 12:21:05 +0000 |
| commit | 49b6d94dd7cd3ad73ae9d4586b3bfb540745347f (patch) | |
| tree | 6e1eb754ebe3f515c3e7db496648dfd1e4645e99 | |
| parent | 089e85f552ec92402d9fcd19d110b0c7521c4601 (diff) | |
| parent | 05cbe2825f00470860200896b20960b66e2549ee (diff) | |
| download | v8-49b6d94dd7cd3ad73ae9d4586b3bfb540745347f.tar.gz | |
Merge "LiteralBuffer::ExpandBuffer always grows" into oc-mr1-dev
| -rw-r--r-- | src/parsing/scanner.cc | 9 | ||||
| -rw-r--r-- | src/parsing/scanner.h | 3 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/parsing/scanner.cc b/src/parsing/scanner.cc index c1580bbe..07757ba9 100644 --- a/src/parsing/scanner.cc +++ b/src/parsing/scanner.cc @@ -67,13 +67,14 @@ Handle<String> Scanner::LiteralBuffer::Internalize(Isolate* isolate) const { } int Scanner::LiteralBuffer::NewCapacity(int min_capacity) { - int capacity = Max(min_capacity, backing_store_.length()); - int new_capacity = Min(capacity * kGrowthFactory, capacity + kMaxGrowth); - return new_capacity; + return min_capacity < (kMaxGrowth / (kGrowthFactor - 1)) + ? min_capacity * kGrowthFactor + : min_capacity + kMaxGrowth; } void Scanner::LiteralBuffer::ExpandBuffer() { - Vector<byte> new_store = Vector<byte>::New(NewCapacity(kInitialCapacity)); + int min_capacity = Max(kInitialCapacity, backing_store_.length()); + Vector<byte> new_store = Vector<byte>::New(NewCapacity(min_capacity)); MemCopy(new_store.start(), backing_store_.start(), position_); backing_store_.Dispose(); backing_store_ = new_store; diff --git a/src/parsing/scanner.h b/src/parsing/scanner.h index 9885b8ed..9cb3f117 100644 --- a/src/parsing/scanner.h +++ b/src/parsing/scanner.h @@ -419,8 +419,7 @@ class Scanner { private: static const int kInitialCapacity = 16; - static const int kGrowthFactory = 4; - static const int kMinConversionSlack = 256; + static const int kGrowthFactor = 4; static const int kMaxGrowth = 1 * MB; inline bool IsValidAscii(char code_unit) { |