diff options
| author | Alexei Frolov <frolv@google.com> | 2023-11-14 19:34:16 +0000 |
|---|---|---|
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-11-14 19:34:16 +0000 |
| commit | 9cd274e4314f3e4d528ea2e9d8c09c0577a068b7 (patch) | |
| tree | 82c4358ae4d8aa290ec983f0af13155542a5831e | |
| parent | b149a27eb616edc55ffa7d6d8a668a782e78eda6 (diff) | |
| download | pigweed-9cd274e4314f3e4d528ea2e9d8c09c0577a068b7.tar.gz | |
pw_transfer: Limit data sent in handler clear test
This applies the same fix from pwrev/180826 to another test where the
issue surfaced.
Bug: 297355578
Change-Id: Ic0411a986c59ba58c03fd7803236a076978e4cd3
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/180951
Reviewed-by: Ted Pudlik <tpudlik@google.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Alexei Frolov <frolv@google.com>
| -rw-r--r-- | pw_transfer/transfer_test.cc | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/pw_transfer/transfer_test.cc b/pw_transfer/transfer_test.cc index 10ca9c529..fcc4e1999 100644 --- a/pw_transfer/transfer_test.cc +++ b/pw_transfer/transfer_test.cc @@ -397,10 +397,12 @@ TEST_F(ReadTransfer, MaxChunkSize_Client) { } TEST_F(ReadTransfer, HandlerIsClearedAfterTransfer) { + // Request an end offset smaller than the data size to prevent the server + // from sending a final chunk. ctx_.SendClientStream( EncodeChunk(Chunk(ProtocolVersion::kLegacy, Chunk::Type::kStart) .set_session_id(3) - .set_window_end_offset(64) + .set_window_end_offset(16) .set_offset(0))); ctx_.SendClientStream( EncodeChunk(Chunk::Final(ProtocolVersion::kLegacy, 3, OkStatus()))); @@ -416,10 +418,12 @@ TEST_F(ReadTransfer, HandlerIsClearedAfterTransfer) { handler_.prepare_read_called = false; handler_.finalize_read_called = false; + // Request an end offset smaller than the data size to prevent the server + // from sending a final chunk. ctx_.SendClientStream( EncodeChunk(Chunk(ProtocolVersion::kLegacy, Chunk::Type::kStart) .set_session_id(3) - .set_window_end_offset(64) + .set_window_end_offset(16) .set_offset(0))); transfer_thread_.WaitUntilEventIsProcessed(); |