diff options
| author | Bartek Nowierski <bartekn@chromium.org> | 2024-05-14 19:29:10 -0700 |
|---|---|---|
| committer | chromeos-ci-prod <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com> | 2024-05-15 04:20:53 -0700 |
| commit | 630deda09a773dd3f0a29a8fce73a0648652094b (patch) | |
| tree | 8e88cd3bc4f02c5b3bc36dd92bd688bc5fe81ebc | |
| parent | c2806e587985206bfa270e834640de55cd1e3771 (diff) | |
| download | libchrome-630deda09a773dd3f0a29a8fce73a0648652094b.tar.gz | |
Revert "[BRP] Disable the extra OOB checks (the core ones remain)"
This reverts commit 1cbdc26ab92876fb37b1a1c5fa4dd0d07ddee697.
Reason for revert: Likely didn't matter for perf after all
Original change's description:
> [BRP] Disable the extra OOB checks (the core ones remain)
>
> Set backup_ref_ptr_extra_oob_checks=false which disables OOB checks
> in operator+/-/[]. Note, OOB checks aren't disabled in
> operator++/--/+=/-=, because their critical to BRP integrity (if the
> pointer was modified to point to another slot, it'd mess up ref-count
> accounting).
>
> This came under scrutiny when evaluating a BRP regression on
> Speedometer3 once Renderer-only code has been rewritten to raw_ptr<>.
> The result is borderline noise, but this is the best hunch we have so
> far:
> https://pinpoint-dot-chromeperf.appspot.com/job/10787d51be0000
>
> Bug: 335556942
> Change-Id: Ic09e126b1b2ff90f0987e03478845d52ed743a50
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465326
> Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
> Reviewed-by: Keishi Hattori <keishi@chromium.org>
> Commit-Queue: Keishi Hattori <keishi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1289787}
Bug: 335556942
Change-Id: I47fa9a5ee11edf71210b45a0235b4267819636d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5507973
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301056}
CrOS-Libchrome-Original-Commit: 6d45cdcd25698f4b424253c87912a44c6bae72ba
| -rw-r--r-- | base/allocator/partition_allocator/partition_alloc.gni | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/base/allocator/partition_allocator/partition_alloc.gni b/base/allocator/partition_allocator/partition_alloc.gni index f421a0172e..a4697dd599 100644 --- a/base/allocator/partition_allocator/partition_alloc.gni +++ b/base/allocator/partition_allocator/partition_alloc.gni @@ -215,7 +215,7 @@ declare_args() { enable_backup_ref_ptr_instance_tracer = false backup_ref_ptr_extra_oob_checks = - false && enable_backup_ref_ptr_support && use_raw_ptr_backup_ref_impl + enable_backup_ref_ptr_support && use_raw_ptr_backup_ref_impl } declare_args() { |