diff options
| author | Kir Kolyshkin <kolyshkin@gmail.com> | 2022-05-17 16:11:10 -0700 |
|---|---|---|
| committer | Lasse Folger <lassefolger@google.com> | 2022-05-23 06:49:14 +0000 |
| commit | 147729ae80a2ba50a4c0d099063831050523a358 (patch) | |
| tree | d77959c809d14bc8fb033dcbb57d6d6dafcea116 | |
| parent | 4790de629c8fc2bda206d4d1f0e521d9fb12a2fe (diff) | |
| download | golang-protobuf-147729ae80a2ba50a4c0d099063831050523a358.tar.gz | |
gha-ci: bump Go version, nits
1. Switch from Go 1.16 to Go 1.x (which should now resolve to Go 1.18.1).
2. Add a comment explaining that the above version is not the actual Go
version used for testing.
3. Drop -mod=vendor as this is the unconditional default since Go 1.16
(unless GO111MODULES overrides this).
4. While at it, fix the options order in go test command, putting options
before the file name.
Tested at https://github.com/kolyshkin/protobuf-go/actions/runs/2342081396
Change-Id: Icc9aa47ddc0d04abb69b48fcb6b021e3e8a98df3
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/406954
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Joseph Tsai <joetsai@digital-static.net>
Reviewed-by: Lasse Folger <lassefolger@google.com>
| -rw-r--r-- | .github/workflows/test.yml | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d03f567e..9cb8570e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -4,7 +4,9 @@ jobs: test: strategy: matrix: - go-version: [1.16.x] + # This is just a version to compile the integration_test.go; see + # golangVersions in that file for the list of actual Go versions used. + go-version: [1.x] os: [ubuntu-latest] # TODO: Add [macos-latest, windows-latest] runs-on: ${{ matrix.os }} steps: @@ -23,4 +25,4 @@ jobs: path: .cache key: ${{ runner.os }}-${{ hashFiles('integration_test.go') }} - name: Test - run: go test -v -mod=vendor -timeout=60m -count=1 integration_test.go -failfast + run: go test -v -timeout=60m -count=1 -failfast integration_test.go |