From 3772724775c58a179fce86e9522b61972437a758 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Thu, 16 May 2024 05:20:03 -0700 Subject: Use `module_version()` to get the version from `MODULE.bazel` Copybara Import from https://github.com/bazelbuild/rules_java/pull/190 BEGIN_PUBLIC Use `module_version()` to get the version from `MODULE.bazel` (#190) Closes #190 END_PUBLIC COPYBARA_INTEGRATE_REVIEW=https://github.com/bazelbuild/rules_java/pull/190 from fmeum:module-version 5964bff12f8290a6f66e2ac9f18a0b243e25f5dc PiperOrigin-RevId: 634331837 Change-Id: I10a94fccdf179e417d626adce5b15718ed9e58fb --- distro/BUILD.bazel | 10 +++------- distro/README.md | 3 +-- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/distro/BUILD.bazel b/distro/BUILD.bazel index daae366..0fa843f 100644 --- a/distro/BUILD.bazel +++ b/distro/BUILD.bazel @@ -1,15 +1,11 @@ load("@rules_pkg//pkg:tar.bzl", "pkg_tar") load("@rules_pkg//pkg/releasing:defs.bzl", "print_rel_notes") -package( - default_visibility = ["//visibility:private"], -) - -_VERSION = "7.6.0" +package(default_visibility = ["//visibility:private"]) # Build the artifact to put on the github release page. pkg_tar( - name = "rules_java-%s" % _VERSION, + name = "rules_java-%s" % module_version(), srcs = ["//:distribution"], extension = "tar.gz", # It is all source code, so make it read-only. @@ -27,5 +23,5 @@ print_rel_notes( repo = "rules_java", setup_file = "java:repositories.bzl", toolchains_method = "rules_java_toolchains", - version = _VERSION, + version = module_version(), ) diff --git a/distro/README.md b/distro/README.md index 428f4eb..7cac892 100644 --- a/distro/README.md +++ b/distro/README.md @@ -1,7 +1,6 @@ # Releasing rules_java -1. Update version in [java/defs.bzl](/java/defs.bzl), - [MODULE.bazel](/MODULE.bazel) and merge it +1. Update version in [MODULE.bazel](/MODULE.bazel) and merge it 2. Build the release running `bazel build //distro:rules_java-{version}` 3. Prepare release notes running `bazel build //distro:relnotes` 4. Create a new release on GitHub -- cgit v1.2.3