aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSon Luong Ngoc <sluongng@gmail.com>2024-05-07 08:57:34 +0200
committerGitHub <noreply@github.com>2024-05-07 08:57:34 +0200
commit6a05f8da2e54097c3e4f574fa551747ade8f3017 (patch)
tree1e1b9bb6728d112d3930d85caac2f09fd0fd2387
parent35b7f07f36de0554868f255901a1db407f87b353 (diff)
downloadbazelbuild-rules_go-6a05f8da2e54097c3e4f574fa551747ade8f3017.tar.gz
go_test: use different mnemonic for compilation (#3936)
Closes #3935
-rw-r--r--go/private/actions/archive.bzl4
-rw-r--r--go/private/actions/compilepkg.bzl5
-rw-r--r--go/private/rules/test.bzl2
3 files changed, 7 insertions, 4 deletions
diff --git a/go/private/actions/archive.bzl b/go/private/actions/archive.bzl
index c518501d..023546f5 100644
--- a/go/private/actions/archive.bzl
+++ b/go/private/actions/archive.bzl
@@ -39,7 +39,7 @@ load(
"cgo_configure",
)
-def emit_archive(go, source = None, _recompile_suffix = "", recompile_internal_deps = None):
+def emit_archive(go, source = None, _recompile_suffix = "", recompile_internal_deps = None, is_external_pkg = False):
"""See go/toolchains.rst#archive for full documentation."""
if source == None:
@@ -122,6 +122,7 @@ def emit_archive(go, source = None, _recompile_suffix = "", recompile_internal_d
objcxxopts = cgo.objcxxopts,
clinkopts = cgo.clinkopts,
testfilter = testfilter,
+ is_external_pkg = is_external_pkg,
)
else:
cgo_deps = depset()
@@ -141,6 +142,7 @@ def emit_archive(go, source = None, _recompile_suffix = "", recompile_internal_d
cgo = False,
testfilter = testfilter,
recompile_internal_deps = recompile_internal_deps,
+ is_external_pkg = is_external_pkg,
)
data = GoArchiveData(
diff --git a/go/private/actions/compilepkg.bzl b/go/private/actions/compilepkg.bzl
index 10fa6970..815213b3 100644
--- a/go/private/actions/compilepkg.bzl
+++ b/go/private/actions/compilepkg.bzl
@@ -72,7 +72,8 @@ def emit_compilepkg(
out_cgo_export_h = None,
gc_goopts = [],
testfilter = None, # TODO: remove when test action compiles packages
- recompile_internal_deps = []):
+ recompile_internal_deps = [],
+ is_external_pkg = False):
"""Compiles a complete Go package."""
if sources == None:
fail("sources is a required parameter")
@@ -179,7 +180,7 @@ def emit_compilepkg(
go.actions.run(
inputs = inputs,
outputs = outputs,
- mnemonic = "GoCompilePkg",
+ mnemonic = "GoCompilePkgExternal" if is_external_pkg else "GoCompilePkg",
executable = go.toolchain._builder,
arguments = [args],
env = go.env,
diff --git a/go/private/rules/test.bzl b/go/private/rules/test.bzl
index 554cd30c..8da3632d 100644
--- a/go/private/rules/test.bzl
+++ b/go/private/rules/test.bzl
@@ -80,7 +80,7 @@ def _go_test_impl(ctx):
x_defs = ctx.attr.x_defs,
), external_library, ctx.coverage_instrumented())
external_source, internal_archive = _recompile_external_deps(go, external_source, internal_archive, [t.label for t in ctx.attr.embed])
- external_archive = go.archive(go, external_source)
+ external_archive = go.archive(go, external_source, is_external_pkg = True)
# now generate the main function
repo_relative_rundir = ctx.attr.rundir or ctx.label.package or "."