diff options
| author | Treehugger Robot <android-test-infra-autosubmit@system.gserviceaccount.com> | 2024-03-06 01:10:49 +0000 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2024-03-06 01:10:49 +0000 |
| commit | d3a0ea94baf6d49aa1b71ecbb76b0429f033bd5d (patch) | |
| tree | 07f87e4c795f9521a411150aef64885dc1ae22c1 | |
| parent | dc2b51f2baf6fdc45f2a34e17eebfe93f739cada (diff) | |
| parent | e11319d4661c0a9b461530d4c0d3ef1a87978571 (diff) | |
| download | soong-d3a0ea94baf6d49aa1b71ecbb76b0429f033bd5d.tar.gz | |
Merge "enable exportable check" into main
| -rw-r--r-- | aconfig/codegen/java_aconfig_library.go | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/aconfig/codegen/java_aconfig_library.go b/aconfig/codegen/java_aconfig_library.go index 7d7296e6a..3d15ac9a9 100644 --- a/aconfig/codegen/java_aconfig_library.go +++ b/aconfig/codegen/java_aconfig_library.go @@ -92,12 +92,12 @@ func (callbacks *JavaAconfigDeclarationsLibraryCallbacks) GenerateSourceJarBuild if !isModeSupported(mode) { ctx.PropertyErrorf("mode", "%q is not a supported mode", mode) } - // TODO: uncomment this part after internal clean up - //if mode == "exported" && !declarations.Exportable { - // // if mode is exported, the corresponding aconfig_declaration must mark its - // // exportable property true - // ctx.PropertyErrorf("mode", "exported mode requires its aconfig_declaration has exportable prop true") - //} + + if mode == "exported" && !declarations.Exportable { + // if mode is exported, the corresponding aconfig_declaration must mark its + // exportable property true + ctx.PropertyErrorf("mode", "exported mode requires its aconfig_declaration has exportable prop true") + } ctx.Build(pctx, android.BuildParams{ Rule: javaRule, |