summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFugang Duan <fugang.duan@nxp.com>2021-06-16 17:14:25 +0800
committerLee Jones <joneslee@google.com>2021-08-19 11:02:16 +0100
commit2a24bfe9a2febe7f3bfd8d34e9f2d07cee9b1a13 (patch)
treeac13c2ee6d748b4e0c77adc97d7de22809d3ba3b
parenta5f80e109955df49e76d5ea0e9693656a931181f (diff)
downloadmediatek-2a24bfe9a2febe7f3bfd8d34e9f2d07cee9b1a13.tar.gz
net: fec_ptp: add clock rate zero check
commit cb3cefe3f3f8af27c6076ef7d1f00350f502055d upstream. Add clock rate zero check to fix coverity issue of "divide by 0". Fixes: commit 85bd1798b24a ("net: fec: fix spin_lock dead lock") Signed-off-by: Fugang Duan <fugang.duan@nxp.com> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Lee Jones <joneslee@google.com> Change-Id: Idf85b5ae13f810918edb00d92dbf54e5312f1eb8
-rw-r--r--drivers/net/ethernet/freescale/fec_ptp.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index 0776fc6e8771..5ce9c3a546fc 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -610,6 +610,10 @@ void fec_ptp_init(struct platform_device *pdev)
fep->ptp_caps.enable = fec_ptp_enable;
fep->cycle_speed = clk_get_rate(fep->clk_ptp);
+ if (!fep->cycle_speed) {
+ fep->cycle_speed = NSEC_PER_SEC;
+ dev_err(&fep->pdev->dev, "clk_ptp clock rate is zero\n");
+ }
fep->ptp_inc = NSEC_PER_SEC / fep->cycle_speed;
spin_lock_init(&fep->tmreg_lock);