summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCathy Hsu <cathsu@google.com>2023-11-13 03:50:18 +0000
committerCathy Hsu <cathsu@google.com>2023-11-16 06:13:15 +0000
commitaf0d0b7fabffc963a447d23384400feb4ce025bd (patch)
tree173fcbbe843834096e863d393e4aff39ac900e64
parent9186974ce6316b2b9405c77a0f319262b7e9d074 (diff)
downloadshusky-af0d0b7fabffc963a447d23384400feb4ce025bd.tar.gz
panel: fix display-related warningsandroid-u-qpr2-beta-2_r0.8
Bug: 309872099 Test: make sure there is no warning when compiling kernel image Change-Id: I8045859b8b8ac60f91728c67f4ceb7b2af523b92 Signed-off-by: Cathy Hsu <cathsu@google.com>
-rw-r--r--display/panel-google-bigsurf.c3
-rw-r--r--display/panel-google-hk3.c14
-rw-r--r--display/panel-google-shoreline.c3
3 files changed, 16 insertions, 4 deletions
diff --git a/display/panel-google-bigsurf.c b/display/panel-google-bigsurf.c
index 403f2b4..0ded27d 100644
--- a/display/panel-google-bigsurf.c
+++ b/display/panel-google-bigsurf.c
@@ -69,8 +69,11 @@ static const u8 bigsurf_lhbm_brightness_reg = 0xD0;
struct bigsurf_panel {
/** @base: base panel struct */
struct exynos_panel base;
+ /** @lhbm_ctl: LHBM control parameters */
struct bigsurf_lhbm_ctl lhbm_ctl;
+ /** @idle_exit_dimming_delay_ts: the delay time to exit dimming */
ktime_t idle_exit_dimming_delay_ts;
+ /** @panel_brightness: the brightness of the panel */
u16 panel_brightness;
};
diff --git a/display/panel-google-hk3.c b/display/panel-google-hk3.c
index 66c296d..74748e0 100644
--- a/display/panel-google-hk3.c
+++ b/display/panel-google-hk3.c
@@ -103,13 +103,17 @@ struct hk3_lhbm_ctl {
bool hist_roi_configured;
};
+#define HK3_VREG_STR_SIZE 11
+#define HK3_VREG_PARAM_NUM 5
+
/**
+ * HK3_VREG_STR
+ * @ctx: exynos_panel struct
+ *
* Expect to have five values for the Vreg parameters:
* EVT1.1 and earlier: 0x1B
* DVT1 and later: 0x1A
*/
-#define HK3_VREG_STR_SIZE 11
-#define HK3_VREG_PARAM_NUM 5
#define HK3_VREG_STR(ctx) (((ctx)->panel_rev >= PANEL_REV_DVT1) ? "1a1a1a1a1a" : "1b1b1b1b1b")
/**
@@ -155,8 +159,9 @@ struct hk3_panel {
struct thermal_zone_device *tz;
/** @hw_temp: the temperature applied into panel */
u32 hw_temp;
- /** @pending_temp_update: whether there is pending temperature update. It will be
- * handled in the commit_done function.
+ /**
+ * @pending_temp_update: whether there is pending temperature update. It will be
+ * handled in the commit_done function.
*/
bool pending_temp_update;
/**
@@ -1419,6 +1424,7 @@ static void hk3_wait_for_vsync_done(struct exynos_panel *ctx, u32 vrefresh, bool
* fake TE at transition from fixed TE to changeable TE.
* @ctx: panel struct
* @vrefresh: current refresh rate
+ * @is_ns: whether it is normal speed or not
*/
static void hk3_wait_for_vsync_done_changeable(struct exynos_panel *ctx, u32 vrefresh, bool is_ns)
{
diff --git a/display/panel-google-shoreline.c b/display/panel-google-shoreline.c
index cc1dcee..9b1fb9a 100644
--- a/display/panel-google-shoreline.c
+++ b/display/panel-google-shoreline.c
@@ -399,6 +399,9 @@ static void shoreline_update_te(struct exynos_panel *ctx, const unsigned int vre
}
/**
+ * shoreline_update_te2 - update the TE2 for shoreline panels
+ * @ctx: panel struct
+ *
* Current definition of the B9h command parameter:
*
* TE2 rising at 120Hz: